Skip to content

Commit 784c316

Browse files
w0xlthebasto
authored andcommitted
scripted-diff: rename m_cs_banned -> m_banned_mutex
-BEGIN VERIFY SCRIPT- s() { sed -i 's/m_cs_banned/m_banned_mutex/g' $1; } s src/banman.cpp s src/banman.h -END VERIFY SCRIPT-
1 parent 46709c5 commit 784c316

File tree

2 files changed

+18
-18
lines changed

2 files changed

+18
-18
lines changed

src/banman.cpp

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ BanMan::~BanMan()
2727

2828
void BanMan::LoadBanlist()
2929
{
30-
LOCK(m_cs_banned);
30+
LOCK(m_banned_mutex);
3131

3232
if (m_client_interface) m_client_interface->InitMessage(_("Loading banlist…").translated);
3333

@@ -51,7 +51,7 @@ void BanMan::DumpBanlist()
5151

5252
banmap_t banmap;
5353
{
54-
LOCK(m_cs_banned);
54+
LOCK(m_banned_mutex);
5555
SweepBanned();
5656
if (!m_is_dirty) return;
5757
banmap = m_banned;
@@ -60,7 +60,7 @@ void BanMan::DumpBanlist()
6060

6161
int64_t n_start = GetTimeMillis();
6262
if (!m_ban_db.Write(banmap)) {
63-
LOCK(m_cs_banned);
63+
LOCK(m_banned_mutex);
6464
m_is_dirty = true;
6565
}
6666

@@ -71,7 +71,7 @@ void BanMan::DumpBanlist()
7171
void BanMan::ClearBanned()
7272
{
7373
{
74-
LOCK(m_cs_banned);
74+
LOCK(m_banned_mutex);
7575
m_banned.clear();
7676
m_is_dirty = true;
7777
}
@@ -81,14 +81,14 @@ void BanMan::ClearBanned()
8181

8282
bool BanMan::IsDiscouraged(const CNetAddr& net_addr)
8383
{
84-
LOCK(m_cs_banned);
84+
LOCK(m_banned_mutex);
8585
return m_discouraged.contains(net_addr.GetAddrBytes());
8686
}
8787

8888
bool BanMan::IsBanned(const CNetAddr& net_addr)
8989
{
9090
auto current_time = GetTime();
91-
LOCK(m_cs_banned);
91+
LOCK(m_banned_mutex);
9292
for (const auto& it : m_banned) {
9393
CSubNet sub_net = it.first;
9494
CBanEntry ban_entry = it.second;
@@ -103,7 +103,7 @@ bool BanMan::IsBanned(const CNetAddr& net_addr)
103103
bool BanMan::IsBanned(const CSubNet& sub_net)
104104
{
105105
auto current_time = GetTime();
106-
LOCK(m_cs_banned);
106+
LOCK(m_banned_mutex);
107107
banmap_t::iterator i = m_banned.find(sub_net);
108108
if (i != m_banned.end()) {
109109
CBanEntry ban_entry = (*i).second;
@@ -122,7 +122,7 @@ void BanMan::Ban(const CNetAddr& net_addr, int64_t ban_time_offset, bool since_u
122122

123123
void BanMan::Discourage(const CNetAddr& net_addr)
124124
{
125-
LOCK(m_cs_banned);
125+
LOCK(m_banned_mutex);
126126
m_discouraged.insert(net_addr.GetAddrBytes());
127127
}
128128

@@ -139,7 +139,7 @@ void BanMan::Ban(const CSubNet& sub_net, int64_t ban_time_offset, bool since_uni
139139
ban_entry.nBanUntil = (normalized_since_unix_epoch ? 0 : GetTime()) + normalized_ban_time_offset;
140140

141141
{
142-
LOCK(m_cs_banned);
142+
LOCK(m_banned_mutex);
143143
if (m_banned[sub_net].nBanUntil < ban_entry.nBanUntil) {
144144
m_banned[sub_net] = ban_entry;
145145
m_is_dirty = true;
@@ -161,7 +161,7 @@ bool BanMan::Unban(const CNetAddr& net_addr)
161161
bool BanMan::Unban(const CSubNet& sub_net)
162162
{
163163
{
164-
LOCK(m_cs_banned);
164+
LOCK(m_banned_mutex);
165165
if (m_banned.erase(sub_net) == 0) return false;
166166
m_is_dirty = true;
167167
}
@@ -172,15 +172,15 @@ bool BanMan::Unban(const CSubNet& sub_net)
172172

173173
void BanMan::GetBanned(banmap_t& banmap)
174174
{
175-
LOCK(m_cs_banned);
175+
LOCK(m_banned_mutex);
176176
// Sweep the banlist so expired bans are not returned
177177
SweepBanned();
178178
banmap = m_banned; //create a thread safe copy
179179
}
180180

181181
void BanMan::SweepBanned()
182182
{
183-
AssertLockHeld(m_cs_banned);
183+
AssertLockHeld(m_banned_mutex);
184184

185185
int64_t now = GetTime();
186186
bool notify_ui = false;

src/banman.h

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -80,17 +80,17 @@ class BanMan
8080
void DumpBanlist();
8181

8282
private:
83-
void LoadBanlist() EXCLUSIVE_LOCKS_REQUIRED(!m_cs_banned);
83+
void LoadBanlist() EXCLUSIVE_LOCKS_REQUIRED(!m_banned_mutex);
8484
//!clean unused entries (if bantime has expired)
85-
void SweepBanned() EXCLUSIVE_LOCKS_REQUIRED(m_cs_banned);
85+
void SweepBanned() EXCLUSIVE_LOCKS_REQUIRED(m_banned_mutex);
8686

87-
RecursiveMutex m_cs_banned;
88-
banmap_t m_banned GUARDED_BY(m_cs_banned);
89-
bool m_is_dirty GUARDED_BY(m_cs_banned){false};
87+
RecursiveMutex m_banned_mutex;
88+
banmap_t m_banned GUARDED_BY(m_banned_mutex);
89+
bool m_is_dirty GUARDED_BY(m_banned_mutex){false};
9090
CClientUIInterface* m_client_interface = nullptr;
9191
CBanDB m_ban_db;
9292
const int64_t m_default_ban_time;
93-
CRollingBloomFilter m_discouraged GUARDED_BY(m_cs_banned) {50000, 0.000001};
93+
CRollingBloomFilter m_discouraged GUARDED_BY(m_banned_mutex) {50000, 0.000001};
9494
};
9595

9696
#endif // BITCOIN_BANMAN_H

0 commit comments

Comments
 (0)