index: refactor-only: Reuse CChain ref

dongcarl · dongcarl · commit 7a799c9c2b86 · 2021-05-27T13:50:11.000-04:00
diff --git a/src/index/base.cpp b/src/index/base.cpp
@@ -60,12 +60,12 @@ bool BaseIndex::Init()
     }
 
     LOCK(cs_main);
+    CChain& active_chain = m_chainstate->m_chain;
     if (locator.IsNull()) {
         m_best_block_index = nullptr;
     } else {
-        m_best_block_index = m_chainstate->m_blockman.FindForkInGlobalIndex(m_chainstate->m_chain, locator);
+        m_best_block_index = m_chainstate->m_blockman.FindForkInGlobalIndex(active_chain, locator);
     }
-    CChain& active_chain = m_chainstate->m_chain;
     m_synced = m_best_block_index.load() == active_chain.Tip();
     if (!m_synced) {
         bool prune_violation = false;

Original file line number	Diff line number	Diff line change
`@@ -60,12 +60,12 @@ bool BaseIndex::Init()`
`60`	`60`	`}`
`61`	`61`
`62`	`62`	`LOCK(cs_main);`
	`63`	`+ CChain& active_chain = m_chainstate->m_chain;`
`63`	`64`	`if (locator.IsNull()) {`
`64`	`65`	`m_best_block_index = nullptr;`
`65`	`66`	`} else {`
`66`		`- m_best_block_index = m_chainstate->m_blockman.FindForkInGlobalIndex(m_chainstate->m_chain, locator);`
	`67`	`+ m_best_block_index = m_chainstate->m_blockman.FindForkInGlobalIndex(active_chain, locator);`
`67`	`68`	`}`
`68`		`- CChain& active_chain = m_chainstate->m_chain;`
`69`	`69`	`m_synced = m_best_block_index.load() == active_chain.Tip();`
`70`	`70`	`if (!m_synced) {`
`71`	`71`	`bool prune_violation = false;`