Skip to content

Commit 7c8e605

Browse files
committed
Merge #21159: test: fix sign comparison warning in socket tests
9cc8e30 test: fix sign comparison warning in socket tests (fanquake) Pull request description: This fixes: ```bash In file included from test/sock_tests.cpp:10: In file included from /usr/local/include/boost/test/unit_test.hpp:18: In file included from /usr/local/include/boost/test/test_tools.hpp:46: /usr/local/include/boost/test/tools/old/impl.hpp:107:17: warning: comparison of integers of different signs: 'const long' and 'const unsigned long' [-Wsign-compare] return left == right; ~~~~ ^ ~~~~~ ``` which was introduced in #20788. ACKs for top commit: practicalswift: cr ACK 9cc8e30 vasild: ACK 9cc8e30 Tree-SHA512: 7069a4fde5cec01be03f8477fe396e53658f170efbf1d9ef3339d553bb90a2be9f4acd6b348127b14cd2f91426e0cd1fc35d2d3c9f201cf748c0cf50f47e46a5
2 parents 92fee79 + 9cc8e30 commit 7c8e605

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/test/sock_tests.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ static void CreateSocketPair(int s[2])
9595
static void SendAndRecvMessage(const Sock& sender, const Sock& receiver)
9696
{
9797
const char* msg = "abcd";
98-
constexpr size_t msg_len = 4;
98+
constexpr ssize_t msg_len = 4;
9999
char recv_buf[10];
100100

101101
BOOST_CHECK_EQUAL(sender.Send(msg, msg_len, 0), msg_len);

0 commit comments

Comments
 (0)