Fail in DecodeHexTx if there is extra data at the end

TheBlueMatt · TheBlueMatt · commit 7ea0ad539ff8 · 2017-02-02T17:32:27.000-05:00
diff --git a/src/core_read.cpp b/src/core_read.cpp
@@ -111,6 +111,8 @@ bool DecodeHexTx(CMutableTransaction& tx, const std::string& strHexTx, bool fTry
     CDataStream ssData(txData, SER_NETWORK, PROTOCOL_VERSION);
     try {
         ssData >> tx;
+        if (!ssData.empty())
+            return false;
     }
     catch (const std::exception&) {
         return false;

Original file line number	Diff line number	Diff line change
`@@ -111,6 +111,8 @@ bool DecodeHexTx(CMutableTransaction& tx, const std::string& strHexTx, bool fTry`
`111`	`111`	`CDataStream ssData(txData, SER_NETWORK, PROTOCOL_VERSION);`
`112`	`112`	`try {`
`113`	`113`	`ssData >> tx;`
	`114`	`+ if (!ssData.empty())`
	`115`	`+ return false;`
`114`	`116`	`}`
`115`	`117`	`catch (const std::exception&) {`
`116`	`118`	`return false;`