Skip to content

Commit 7ebc365

Browse files
committed
Merge #19214: Auto-detect SHA256 implementation in benchmarks
addf18d Call SHA256AutoDetect in benchmark setup (Pieter Wuille) Pull request description: It seems `SHA256AutoDetect()` was not being called in benchmarks, making the numbers only reflect the naive implementation. Fix this by calling it in bench_bitcoin's setup. ACKs for top commit: fjahr: tested ACK addf18d pstratem: ACK addf18d laanwj: ACK addf18d Tree-SHA512: 3ba4b068145942df1429bf5913e3f685511e6ebeae2c1a3f9b8ac0144f6db1c7df456f88f480a2129f3e1602e3bf6a39530bb96e2c74c03ddb19324cec6799c7
2 parents 4312559 + addf18d commit 7ebc365

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

src/bench/bench_bitcoin.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44

55
#include <bench/bench.h>
66

7+
#include <crypto/sha256.h>
78
#include <util/strencodings.h>
89
#include <util/system.h>
910

@@ -35,6 +36,7 @@ int main(int argc, char** argv)
3536
{
3637
ArgsManager argsman;
3738
SetupBenchArgs(argsman);
39+
SHA256AutoDetect();
3840
std::string error;
3941
if (!argsman.ParseParameters(argc, argv, error)) {
4042
tfm::format(std::cerr, "Error parsing command line arguments: %s\n", error);

0 commit comments

Comments
 (0)