Skip to content

Commit 7f81250

Browse files
committed
Mention that other RPC calls report keys as "imported" while txns are still missing
1 parent ccd8ef6 commit 7f81250

File tree

1 file changed

+8
-3
lines changed

1 file changed

+8
-3
lines changed

src/wallet/rpcdump.cpp

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,8 @@ UniValue importprivkey(const JSONRPCRequest& request)
8686
"1. \"privkey\" (string, required) The private key (see dumpprivkey)\n"
8787
"2. \"label\" (string, optional, default=\"\") An optional label\n"
8888
"3. rescan (boolean, optional, default=true) Rescan the wallet for transactions\n"
89-
"\nNote: This call can take minutes to complete if rescan is true.\n"
89+
"\nNote: This call can take minutes to complete if rescan is true, during that time, other rpc calls\n"
90+
"may report that the imported key exists but related transactions are still missing, leading to temporarily incorrect/bogus balances and unspent outputs until rescan completes.\n"
9091
"\nExamples:\n"
9192
"\nDump a private key\n"
9293
+ HelpExampleCli("dumpprivkey", "\"myaddress\"") +
@@ -241,7 +242,8 @@ UniValue importaddress(const JSONRPCRequest& request)
241242
"2. \"label\" (string, optional, default=\"\") An optional label\n"
242243
"3. rescan (boolean, optional, default=true) Rescan the wallet for transactions\n"
243244
"4. p2sh (boolean, optional, default=false) Add the P2SH version of the script as well\n"
244-
"\nNote: This call can take minutes to complete if rescan is true.\n"
245+
"\nNote: This call can take minutes to complete if rescan is true, during that time, other rpc calls\n"
246+
"may report that the imported address exists but related transactions are still missing, leading to temporarily incorrect/bogus balances and unspent outputs until rescan completes.\n"
245247
"If you have the full public key, you should call importpubkey instead of this.\n"
246248
"\nNote: If you import a non-standard raw script in hex form, outputs sending to it will be treated\n"
247249
"as change, and not show up in many RPCs.\n"
@@ -416,7 +418,8 @@ UniValue importpubkey(const JSONRPCRequest& request)
416418
"1. \"pubkey\" (string, required) The hex-encoded public key\n"
417419
"2. \"label\" (string, optional, default=\"\") An optional label\n"
418420
"3. rescan (boolean, optional, default=true) Rescan the wallet for transactions\n"
419-
"\nNote: This call can take minutes to complete if rescan is true.\n"
421+
"\nNote: This call can take minutes to complete if rescan is true, during that time, other rpc calls\n"
422+
"may report that the imported pubkey exists but related transactions are still missing, leading to temporarily incorrect/bogus balances and unspent outputs until rescan completes.\n"
420423
"\nExamples:\n"
421424
"\nImport a public key with rescan\n"
422425
+ HelpExampleCli("importpubkey", "\"mypubkey\"") +
@@ -1133,6 +1136,8 @@ UniValue importmulti(const JSONRPCRequest& mainRequest)
11331136
" {\n"
11341137
" \"rescan\": <false>, (boolean, optional, default: true) Stating if should rescan the blockchain after all imports\n"
11351138
" }\n"
1139+
"\nNote: This call can take minutes to complete if rescan is true, during that time, other rpc calls\n"
1140+
"may report that the imported keys, addresses or scripts exists but related transactions are still missing.\n"
11361141
"\nExamples:\n" +
11371142
HelpExampleCli("importmulti", "'[{ \"scriptPubKey\": { \"address\": \"<my address>\" }, \"timestamp\":1455191478 }, "
11381143
"{ \"scriptPubKey\": { \"address\": \"<my 2nd address>\" }, \"label\": \"example 2\", \"timestamp\": 1455191480 }]'") +

0 commit comments

Comments
 (0)