Skip to content

Commit 7fbbd6f

Browse files
committed
Merge #16746: msbuild: Ignore linker warning
aff1c9c Adds an option to msbuild common configuration to ignore linker warning 4221. This warning is for object files that do not include any symbols. The warning is harmless and occurs due to some classes that are *nix only having no source to compile for an msvc build. (Aaron Clauson) Pull request description: Adds an option to msbuild common configuration to ignore linker warning 4221. This warning is for object files that do not include any symbols. The warning is harmless and occurs due to some classes that are *nix only having no source to compile for an msvc build. ACKs for top commit: MarcoFalke: ACK aff1c9c hebasto: ACK aff1c9c, I have reviewed the code, it looks OK and I agree it can be merged. fanquake: ACK aff1c9c Tree-SHA512: fda3721462d927d8734e16fc0250c7c76b197a085219a9e5267cdd14e19f23f50807d6b5516dee8402b60f3fdf188677e3d618fe6acbdbb5ac3bb635aeb7b297
2 parents 93305e6 + aff1c9c commit 7fbbd6f

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

build_msvc/common.init.vcxproj

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -113,6 +113,9 @@
113113
<GenerateDebugInformation>true</GenerateDebugInformation>
114114
<AdditionalDependencies>crypt32.lib;Iphlpapi.lib;ws2_32.lib;Shlwapi.lib;kernel32.lib;user32.lib;gdi32.lib;winspool.lib;comdlg32.lib;advapi32.lib;shell32.lib;ole32.lib;oleaut32.lib;uuid.lib;odbc32.lib;odbccp32.lib;%(AdditionalDependencies)</AdditionalDependencies>
115115
</Link>
116+
<Lib>
117+
<AdditionalOptions>/ignore:4221</AdditionalOptions>
118+
</Lib>
116119
</ItemDefinitionGroup>
117120
<Import Project="common.init.vcxproj.user" Condition="Exists('common.init.vcxproj.user')" />
118121
</Project>

0 commit comments

Comments
 (0)