Skip to content

Commit 8164641

Browse files
author
MarcoFalke
committed
Merge #17851: tests: Add std::to_string to list of locale dependent functions
1f0adb3 tests: Add std::to_string to list of locale dependent functions (practicalswift) Pull request description: Add `std::to_string` to list of locale dependent functions: > `std::to_string` relies on the current locale for formatting purposes […] Context bitcoin/bitcoin#17808 (comment) ACKs for top commit: hebasto: ACK 1f0adb3, I have reviewed the code and it looks OK, I agree it can be merged. Tree-SHA512: 4cd6f567f5931dd166cdb9b065a939fb0bc02c93de18a9501655d98caf18b7c4d81f1881ea900dcdf2ec103d3ab1bdc9c68d3257b76dd2468a59e74d278b0d8d
2 parents 17e14ac + 1f0adb3 commit 8164641

File tree

1 file changed

+17
-0
lines changed

1 file changed

+17
-0
lines changed

test/lint/lint-locale-dependence.sh

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,22 +3,38 @@
33
export LC_ALL=C
44
KNOWN_VIOLATIONS=(
55
"src/bitcoin-tx.cpp.*stoul"
6+
"src/bitcoin-tx.cpp.*std::to_string"
67
"src/bitcoin-tx.cpp.*trim_right"
78
"src/dbwrapper.cpp.*stoul"
89
"src/dbwrapper.cpp:.*vsnprintf"
910
"src/httprpc.cpp.*trim"
1011
"src/init.cpp:.*atoi"
12+
"src/qt/optionsmodel.cpp.*std::to_string"
1113
"src/qt/rpcconsole.cpp:.*atoi"
1214
"src/rest.cpp:.*strtol"
15+
"src/rpc/net.cpp.*std::to_string"
16+
"src/rpc/rawtransaction.cpp.*std::to_string"
17+
"src/rpc/util.cpp.*std::to_string"
18+
"src/test/addrman_tests.cpp.*std::to_string"
19+
"src/test/blockchain_tests.cpp.*std::to_string"
1320
"src/test/dbwrapper_tests.cpp:.*snprintf"
21+
"src/test/denialofservice_tests.cpp.*std::to_string"
1422
"src/test/fuzz/parse_numbers.cpp:.*atoi"
23+
"src/test/key_tests.cpp.*std::to_string"
24+
"src/test/net_tests.cpp.*std::to_string"
25+
"src/test/settings_tests.cpp.*std::to_string"
26+
"src/test/timedata_tests.cpp.*std::to_string"
27+
"src/test/util/setup_common.cpp.*std::to_string"
28+
"src/test/util_tests.cpp.*std::to_string"
29+
"src/test/util_threadnames_tests.cpp.*std::to_string"
1530
"src/torcontrol.cpp:.*atoi"
1631
"src/torcontrol.cpp:.*strtol"
1732
"src/util/strencodings.cpp:.*atoi"
1833
"src/util/strencodings.cpp:.*strtol"
1934
"src/util/strencodings.cpp:.*strtoul"
2035
"src/util/strencodings.h:.*atoi"
2136
"src/util/system.cpp:.*atoi"
37+
"src/wallet/scriptpubkeyman.cpp.*std::to_string"
2238
)
2339

2440
REGEXP_IGNORE_EXTERNAL_DEPENDENCIES="^src/(crypto/ctaes/|leveldb/|secp256k1/|tinyformat.h|univalue/)"
@@ -93,6 +109,7 @@ LOCALE_DEPENDENT_FUNCTIONS=(
93109
snprintf
94110
sprintf
95111
sscanf
112+
std::to_string
96113
stod
97114
stof
98115
stoi

0 commit comments

Comments
 (0)