Skip to content

Commit 819ca3f

Browse files
committed
Remove mapOrphanTransactionsByPrev from DoS_tests
This is another violation of the one definition rule, as the type for mapOrphanTransactionsByPrev did not match the one in net_processing.cpp anymore. As it now depends on a custom Iterator, it seems too much hassle to correctly expose it to the tests. Instead, this commit just removes the one test it was referenced in.
1 parent 7d5d449 commit 819ca3f

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

src/test/DoS_tests.cpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@ struct COrphanTx {
3232
int64_t nTimeExpire;
3333
};
3434
extern std::map<uint256, COrphanTx> mapOrphanTransactions;
35-
extern std::map<uint256, std::set<uint256> > mapOrphanTransactionsByPrev;
3635

3736
CService ip(uint32_t i)
3837
{
@@ -203,7 +202,6 @@ BOOST_AUTO_TEST_CASE(DoS_mapOrphans)
203202
BOOST_CHECK(mapOrphanTransactions.size() <= 10);
204203
LimitOrphanTxSize(0);
205204
BOOST_CHECK(mapOrphanTransactions.empty());
206-
BOOST_CHECK(mapOrphanTransactionsByPrev.empty());
207205
}
208206

209207
BOOST_AUTO_TEST_SUITE_END()

0 commit comments

Comments
 (0)