rpc/createrawtransaction: redefine addresses as OBJ_USER_KEYS

kallewoof · kallewoof · commit 8500f7bf54d3 · 2021-05-09T22:22:25.000+09:00
The OBJ type is for actual objects with defined keys; OBJ_USER_KEYS is for objects with user-defined keys (such as the bitcoin address(es) in the createrawtransaction output object.
diff --git a/src/rpc/rawtransaction.cpp b/src/rpc/rawtransaction.cpp
@@ -397,7 +397,7 @@ static RPCHelpMan createrawtransaction()
                             "For compatibility reasons, a dictionary, which holds the key-value pairs directly, is also\n"
                             "                             accepted as second parameter.",
                         {
-                            {"", RPCArg::Type::OBJ, RPCArg::Optional::OMITTED, "",
+                            {"", RPCArg::Type::OBJ_USER_KEYS, RPCArg::Optional::OMITTED, "",
                                 {
                                     {"address", RPCArg::Type::AMOUNT, RPCArg::Optional::NO, "A key-value pair. The key (string) is the bitcoin address, the value (float or string) is the amount in " + CURRENCY_UNIT},
                                 },

Original file line number	Diff line number	Diff line change
`@@ -397,7 +397,7 @@ static RPCHelpMan createrawtransaction()`
`397`	`397`	`"For compatibility reasons, a dictionary, which holds the key-value pairs directly, is also\n"`
`398`	`398`	`" accepted as second parameter.",`
`399`	`399`	`{`
`400`		`- {"", RPCArg::Type::OBJ, RPCArg::Optional::OMITTED, "",`
	`400`	`+ {"", RPCArg::Type::OBJ_USER_KEYS, RPCArg::Optional::OMITTED, "",`
`401`	`401`	`{`
`402`	`402`	`{"address", RPCArg::Type::AMOUNT, RPCArg::Optional::NO, "A key-value pair. The key (string) is the bitcoin address, the value (float or string) is the amount in " + CURRENCY_UNIT},`
`403`	`403`	`},`