Skip to content

Commit 854b36c

Browse files
author
MarcoFalke
committed
Merge bitcoin-core#138: unlock encrypted wallet "OK" button bugfix
8008ef7 qt: unlock wallet "OK" button bugfix (Michael Dietz) Pull request description: When trying to send a transaction from an encrypted wallet, the ask passphrase dialog would not allow the user to click the "OK" button and proceed. Therefore it was impossible to send a transaction through the gui. It was not enabling the "OK" button after the passphrase was entered by the user, because it was using the same form validation logic as the "Change passphrase" flow. I reported this in a comment in bitcoin-core#136. But then I realized this seems to be a flat out bug. ACKs for top commit: MarcoFalke: review ACK 8008ef7 hebasto: ACK 8008ef7, I have reviewed the code and it looks OK, I agree it can be merged. Tree-SHA512: cc09b34c7f3aea09729e1c7ccccff05dc11fec56fee2ad369f2d862979572b1edd8b7e738ffe6e91d35d071b819b0c3e0f5d48bf5e27427a80af4a28893f8aaf
2 parents 1ae5758 + 8008ef7 commit 854b36c

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

src/qt/askpassphrasedialog.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -199,6 +199,8 @@ void AskPassphraseDialog::textChanged()
199199
acceptable = !ui->passEdit2->text().isEmpty() && !ui->passEdit3->text().isEmpty();
200200
break;
201201
case Unlock: // Old passphrase x1
202+
acceptable = !ui->passEdit1->text().isEmpty();
203+
break;
202204
case ChangePass: // Old passphrase x1, new passphrase x2
203205
acceptable = !ui->passEdit1->text().isEmpty() && !ui->passEdit2->text().isEmpty() && !ui->passEdit3->text().isEmpty();
204206
break;

0 commit comments

Comments
 (0)