Remove duplicate destination decoding

promag · promag · commit 86e6dd4b6302 · 2017-09-06T23:48:35.000+01:00
diff --git a/src/qt/transactiondesc.cpp b/src/qt/transactiondesc.cpp
@@ -91,8 +91,8 @@ QString TransactionDesc::toHTML(CWallet *wallet, CWalletTx &wtx, TransactionReco
         if (nNet > 0)
         {
             // Credit
-            if (IsValidDestinationString(rec->address)) {
-                CTxDestination address = DecodeDestination(rec->address);
+            CTxDestination address = DecodeDestination(rec->address);
+            if (IsValidDestination(address)) {
                 if (wallet->mapAddressBook.count(address))
                 {
                     strHTML += "<b>" + tr("From") + ":</b> " + tr("unknown") + "<br>";

Original file line number	Diff line number	Diff line change
`@@ -91,8 +91,8 @@ QString TransactionDesc::toHTML(CWallet *wallet, CWalletTx &wtx, TransactionReco`
`91`	`91`	`if (nNet > 0)`
`92`	`92`	`{`
`93`	`93`	`// Credit`
`94`		`- if (IsValidDestinationString(rec->address)) {`
`95`		`- CTxDestination address = DecodeDestination(rec->address);`
	`94`	`+ CTxDestination address = DecodeDestination(rec->address);`
	`95`	`+ if (IsValidDestination(address)) {`
`96`	`96`	`if (wallet->mapAddressBook.count(address))`
`97`	`97`	`{`
`98`	`98`	`strHTML += "<b>" + tr("From") + ":</b> " + tr("unknown") + "<br>";`