Merge #21633: refactor: add [[noreturn]] attribute where applicable

fanquake · fanquake · commit 88331aa8a762 · 2021-04-13T21:17:20.000+08:00
003929c refactor: add [[noreturn]] attribute where applicable (fanquake) Pull request description: Similar to #10843. We could build with `-Wmissing-noreturn`, however that would also mean modifying something like `--suppress-external-warnings` to suppress warnings for leveldb, which I don't think we want to do. In any case, the functions where this is applicable are only added/removed very rarely. ACKs for top commit: vasild: ACK 003929c Tree-SHA512: 33dfa6547d6b84f38a941f24d4c2effe8fde7b93dbc0b27a9309716420e4a879fdbe689d789fa5439d65f5f78292f89fd9dc1b61c97acf69316dfed954086705
diff --git a/src/test/util_tests.cpp b/src/test/util_tests.cpp
@@ -1766,7 +1766,7 @@ static constexpr char LockCommand = 'L';
 static constexpr char UnlockCommand = 'U';
 static constexpr char ExitCommand = 'X';
 
-static void TestOtherProcess(fs::path dirname, std::string lockname, int fd)
+[[noreturn]] static void TestOtherProcess(fs::path dirname, std::string lockname, int fd)
 {
     char ch;
     while (true) {

Original file line number	Diff line number	Diff line change
`@@ -1766,7 +1766,7 @@ static constexpr char LockCommand = 'L';`
`1766`	`1766`	`static constexpr char UnlockCommand = 'U';`
`1767`	`1767`	`static constexpr char ExitCommand = 'X';`
`1768`	`1768`
`1769`		`-static void TestOtherProcess(fs::path dirname, std::string lockname, int fd)`
	`1769`	`+[[noreturn]] static void TestOtherProcess(fs::path dirname, std::string lockname, int fd)`
`1770`	`1770`	`{`
`1771`	`1771`	`char ch;`
`1772`	`1772`	`while (true) {`