util: Fail to parse empty string in ParseMoney

Author: MarcoFalke

src/test/util_tests.cpp

@@ -1199,6 +1199,12 @@ BOOST_AUTO_TEST_CASE(util_ParseMoney)
     BOOST_CHECK(ParseMoney("0.00000001", ret));
     BOOST_CHECK_EQUAL(ret, COIN/100000000);
 
+    // Parsing amount that can not be represented in ret should fail
+    BOOST_CHECK(!ParseMoney("0.000000001", ret));
+
+    // Parsing empty string should fail
+    BOOST_CHECK(!ParseMoney("", ret));
+
     // Attempted 63 bit overflow should fail
     BOOST_CHECK(!ParseMoney("92233720368.54775808", ret));
 

src/util/moneystr.cpp

@@ -37,6 +37,10 @@ bool ParseMoney(const std::string& str, CAmount& nRet)
         return false;
     }
 
+    if (str.empty()) {
+        return false;
+    }
+
     std::string strWhole;
     int64_t nUnits = 0;
     const char* p = str.c_str();