Remove redundant nLastTry check

MarcoFalke · MacroFake · commit 8888bd43c100 · 2022-06-08T13:35:32.000+02:00
All other places calculate "now - nLastTry", which is safe and correct
to do when nLastTry is 0. So do the same here.
diff --git a/src/addrman.cpp b/src/addrman.cpp
@@ -66,8 +66,9 @@ int AddrInfo::GetBucketPosition(const uint256& nKey, bool fNew, int nBucket) con
 
 bool AddrInfo::IsTerrible(int64_t nNow) const
 {
-    if (nLastTry && nLastTry >= nNow - 60) // never remove things tried in the last minute
+    if (nNow - nLastTry <= 60) { // never remove things tried in the last minute
         return false;
+    }
 
     if (nTime > nNow + 10 * 60) // came in a flying DeLorean
         return true;

Original file line number	Diff line number	Diff line change
`@@ -66,8 +66,9 @@ int AddrInfo::GetBucketPosition(const uint256& nKey, bool fNew, int nBucket) con`
`66`	`66`
`67`	`67`	`bool AddrInfo::IsTerrible(int64_t nNow) const`
`68`	`68`	`{`
`69`		`- if (nLastTry && nLastTry >= nNow - 60) // never remove things tried in the last minute`
	`69`	`+ if (nNow - nLastTry <= 60) { // never remove things tried in the last minute`
`70`	`70`	`return false;`
	`71`	`+ }`
`71`	`72`
`72`	`73`	`if (nTime > nNow + 10 * 60) // came in a flying DeLorean`
`73`	`74`	`return true;`