Merge #18777: wallet: Recommend absolute path for dumpwallet

MarcoFalke · MarcoFalke · commit 8bdb2134fc80 · 2020-04-27T18:02:52.000-04:00
fa50170 wallet: Recommned absolute path for dumpwallet (MarcoFalke) Pull request description: Avoids misunderstandings such as #9564 ACKs for top commit: kristapsk: utACK fa50170 Tree-SHA512: f675ef607992857ffeb556a2945b5436a70b39c5d83f05a8be15a6fccc84cbe9d03e52f8239e28d159e41ed7c6f119b7a38e8ab327029f04609f63c559c12c49
diff --git a/src/wallet/rpcdump.cpp b/src/wallet/rpcdump.cpp
@@ -735,7 +735,7 @@ UniValue dumpwallet(const JSONRPCRequest& request)
                 "Note that if your wallet contains keys which are not derived from your HD seed (e.g. imported keys), these are not covered by\n"
                 "only backing up the seed itself, and must be backed up too (e.g. ensure you back up the whole dumpfile).\n",
                 {
-                    {"filename", RPCArg::Type::STR, RPCArg::Optional::NO, "The filename with path (either absolute or relative to bitcoind)"},
+                    {"filename", RPCArg::Type::STR, RPCArg::Optional::NO, "The filename with path (absolute path recommended)"},
                 },
                 RPCResult{
                     RPCResult::Type::OBJ, "", "",

Original file line number	Diff line number	Diff line change
`@@ -735,7 +735,7 @@ UniValue dumpwallet(const JSONRPCRequest& request)`
`735`	`735`	`"Note that if your wallet contains keys which are not derived from your HD seed (e.g. imported keys), these are not covered by\n"`
`736`	`736`	`"only backing up the seed itself, and must be backed up too (e.g. ensure you back up the whole dumpfile).\n",`
`737`	`737`	`{`
`738`		`- {"filename", RPCArg::Type::STR, RPCArg::Optional::NO, "The filename with path (either absolute or relative to bitcoind)"},`
	`738`	`+ {"filename", RPCArg::Type::STR, RPCArg::Optional::NO, "The filename with path (absolute path recommended)"},`
`739`	`739`	`},`
`740`	`740`	`RPCResult{`
`741`	`741`	`RPCResult::Type::OBJ, "", "",`