Skip to content

Commit 8cb4307

Browse files
author
MarcoFalke
committed
Merge bitcoin/bitcoin#22271: fuzz: Assert roundtrip equality for CPubKey
9550dff fuzz: Assert roundtrip equality for `CPubKey` (Sebastian Falbesoner) Pull request description: This PR is a (quite late) follow-up to #19237 (bitcoin/bitcoin#19237 (comment)). Looking at `CPubKey::Serialize` and `CPubKey::Unserialize` I can't think of a scenario where the roundtrip (serialization/deserialization) equality wouldn't hold. ACKs for top commit: jamesob: crACK bitcoin/bitcoin@9550dff pending CI Tree-SHA512: 640fb9e777d249769b22ee52c0b15a68ff0645b16c986e1c0bce9742155d14f1be601e591833e1dc8dcffebf271966c6b861b90888a44aae1feae2e0248e2c55
2 parents 7b45c5e + 9550dff commit 8cb4307

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

src/test/fuzz/deserialize.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -136,8 +136,7 @@ FUZZ_TARGET_DESERIALIZE(partial_merkle_tree_deserialize, {
136136
FUZZ_TARGET_DESERIALIZE(pub_key_deserialize, {
137137
CPubKey pub_key;
138138
DeserializeFromFuzzingInput(buffer, pub_key);
139-
// TODO: The following equivalence should hold for CPubKey? Fix.
140-
// AssertEqualAfterSerializeDeserialize(pub_key);
139+
AssertEqualAfterSerializeDeserialize(pub_key);
141140
})
142141
FUZZ_TARGET_DESERIALIZE(script_deserialize, {
143142
CScript script;

0 commit comments

Comments
 (0)