Merge #12932: wallet: Remove redundant lambda function arg in handleTransactionChanged

MarcoFalke · MarcoFalke · commit 8d651ae32013 · 2018-04-10T10:57:10.000-04:00
9b9d717 wallet: Remove redundant lambda function arg in handleTransactionChanged (Wladimir J. van der Laan) Pull request description: Makes the build warning-clean again here: bitcoin/src/interfaces/wallet.cpp:425:18: warning: lambda capture 'this' is not used [-Wunused-lambda-capture] [fn, this](CWallet*, const uint256& txid, ChangeType status) { fn(txid, status); })); ^ Tree-SHA512: 82362c8fb3638246a6c3b28998165eed8a6490f9e13cf2741fb2776ef7f82a1c0bb5ea1f58b7ff842bd59c9830f59f5a478fb63860693055c4d8dd72a94d8a5a
diff --git a/src/interfaces/wallet.cpp b/src/interfaces/wallet.cpp
@@ -422,7 +422,7 @@ class WalletImpl : public Wallet
     std::unique_ptr<Handler> handleTransactionChanged(TransactionChangedFn fn) override
     {
         return MakeHandler(m_wallet.NotifyTransactionChanged.connect(
-            [fn, this](CWallet*, const uint256& txid, ChangeType status) { fn(txid, status); }));
+            [fn](CWallet*, const uint256& txid, ChangeType status) { fn(txid, status); }));
     }
     std::unique_ptr<Handler> handleWatchOnlyChanged(WatchOnlyChangedFn fn) override
     {

Original file line number	Diff line number	Diff line change
`@@ -422,7 +422,7 @@ class WalletImpl : public Wallet`
`422`	`422`	`std::unique_ptr<Handler> handleTransactionChanged(TransactionChangedFn fn) override`
`423`	`423`	`{`
`424`	`424`	`return MakeHandler(m_wallet.NotifyTransactionChanged.connect(`
`425`		`- [fn, this](CWallet*, const uint256& txid, ChangeType status) { fn(txid, status); }));`
	`425`	`+ [fn](CWallet*, const uint256& txid, ChangeType status) { fn(txid, status); }));`
`426`	`426`	`}`
`427`	`427`	`std::unique_ptr<Handler> handleWatchOnlyChanged(WatchOnlyChangedFn fn) override`
`428`	`428`	`{`