Skip to content

Commit 8e69370

Browse files
author
MarcoFalke
committed
Merge #21712: qa: Test default include_mempool value of gettxout
44dab42 qa: Test default include_mempool value of gettxout (João Barbosa) Pull request description: With the following diff the functional test would pass. Fix by testing the default value. ```diff --- a/src/rpc/blockchain.cpp +++ b/src/rpc/blockchain.cpp @@ -1142,7 +1142,7 @@ static RPCHelpMan gettxout() uint256 hash(ParseHashV(request.params[0], "txid")); int n = request.params[1].get_int(); COutPoint out(hash, n); - bool fMempool = true; + bool fMempool = false; if (!request.params[2].isNull()) fMempool = request.params[2].get_bool(); ``` ACKs for top commit: MarcoFalke: cr ACK 44dab42 Tree-SHA512: 14db21b29d6b2c01d1d1278e18a0cf35d6ae566e33e45515d1fe2983dda94ad1ff6065c217601d283f9515cae39b57e981b62ac71ec2002de5359bd8a9e3efa9
2 parents 585cbe2 + 44dab42 commit 8e69370

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

test/functional/wallet_basic.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -95,6 +95,8 @@ def run_test(self):
9595
# but invisible if you include mempool
9696
txout = self.nodes[0].gettxout(confirmed_txid, confirmed_index, False)
9797
assert_equal(txout['value'], 50)
98+
txout = self.nodes[0].gettxout(confirmed_txid, confirmed_index) # by default include_mempool=True
99+
assert txout is None
98100
txout = self.nodes[0].gettxout(confirmed_txid, confirmed_index, True)
99101
assert txout is None
100102
# new utxo from mempool should be invisible if you exclude mempool

0 commit comments

Comments
 (0)