Skip to content

Commit 9111df9

Browse files
author
MarcoFalke
committed
Merge #10219: Tests: Order Python Tests Differently
637706d Tests: Put Extended tests first when they're included (Jimmy Song) Tree-SHA512: 0a720b2443b3e65f4ad548ecdf822468460fc4f4ecf32385dd79511a01c9ea4c94f0bf765ca593705b19baee1bae254dfcc3952da64b9c51d75b7da7abcdcd28
2 parents a86255b + 637706d commit 9111df9

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

test/README.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,8 @@ The ZMQ functional test requires a python ZMQ library. To install it:
2525
Running tests locally
2626
=====================
2727

28+
Build for your system first. Be sure to enable wallet, utils and daemon when you configure. Tests will not run otherwise.
29+
2830
Functional tests
2931
----------------
3032

test/functional/test_runner.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,8 @@
148148
'replace-by-fee.py',
149149
]
150150

151-
ALL_SCRIPTS = BASE_SCRIPTS + ZMQ_SCRIPTS + EXTENDED_SCRIPTS
151+
# Place EXTENDED_SCRIPTS first since it has the 3 longest running tests
152+
ALL_SCRIPTS = EXTENDED_SCRIPTS + BASE_SCRIPTS + ZMQ_SCRIPTS
152153

153154
NON_SCRIPTS = [
154155
# These are python files that live in the functional tests directory, but are not test scripts.
@@ -226,10 +227,9 @@ def main():
226227
if enable_zmq:
227228
test_list += ZMQ_SCRIPTS
228229
if args.extended:
229-
test_list += EXTENDED_SCRIPTS
230-
# TODO: BASE_SCRIPTS and EXTENDED_SCRIPTS are sorted by runtime
231-
# (for parallel running efficiency). This combined list will is no
232-
# longer sorted.
230+
# place the EXTENDED_SCRIPTS first since the three longest ones
231+
# are there and the list is shorter
232+
test_list = EXTENDED_SCRIPTS + test_list
233233

234234
# Remove the test cases that the user has explicitly asked to exclude.
235235
if args.exclude:

0 commit comments

Comments
 (0)