Skip to content

Commit 92f3a4b

Browse files
author
MarcoFalke
committed
Merge bitcoin/bitcoin#22742: test: Use proper target in do_fund_send
8dcbbbe test: fix bug in 22686 (S3RK) Pull request description: It seems there is a bug in the test in #22686, the code behaviour itself looks correct. Instead of verifying the scenario from #22670 with both `upper_bound` and `lower_bound` for the transaction amount, the tests verified `lower_bound` two times. This fix is to properly use function parameter instead of a variable from the scope. The test still passes with both values, so no code changes are required. ACKs for top commit: achow101: ACK 8dcbbbe Tree-SHA512: 82837b2e00bd075a7b6b7a31031f4d3ba1ab4bd5967e90488f527fcc618aeb3945d6ae3ed66b9eb11616dda3ef376c5001559d2a7a79a759fc6800358bf52537
2 parents b6a8e68 + 8dcbbbe commit 92f3a4b

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

test/functional/rpc_fundrawtransaction.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1006,7 +1006,7 @@ def test_22670(self):
10061006
assert_greater_than(fees, 0.01)
10071007

10081008
def do_fund_send(target):
1009-
create_tx = tester.createrawtransaction([], [{funds.getnewaddress(): lower_bound}])
1009+
create_tx = tester.createrawtransaction([], [{funds.getnewaddress(): target}])
10101010
funded_tx = tester.fundrawtransaction(create_tx)
10111011
signed_tx = tester.signrawtransactionwithwallet(funded_tx["hex"])
10121012
assert signed_tx["complete"]

0 commit comments

Comments
 (0)