Skip to content

Commit 95b16e7

Browse files
author
merge-script
committed
Merge bitcoin/bitcoin#23072: log: Remove unnecessary timing of Callbacks bench
ab27800 log: Remove unnecessary timing logs for Callbacks bench (Douglas Chimento) Pull request description: Logging of Callbacks are no longer needed and records times that are not relevant for performance analysis. resolves #23071 ACKs for top commit: laanwj: Thanks. re-ACK ab27800 jonatack: Code review ACK ab27800 Tree-SHA512: be1ea780c4db9407a8799065a8824b9d3610abac72af5907809ed62d493d5a54e65735de45ec5fdd0edb85ef21ec6036105abe8ca00093942980f6f92e7fec50
2 parents cdce149 + ab27800 commit 95b16e7

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

src/validation.cpp

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1572,7 +1572,6 @@ static int64_t nTimeForks = 0;
15721572
static int64_t nTimeVerify = 0;
15731573
static int64_t nTimeConnect = 0;
15741574
static int64_t nTimeIndex = 0;
1575-
static int64_t nTimeCallbacks = 0;
15761575
static int64_t nTimeTotal = 0;
15771576
static int64_t nBlocksTotal = 0;
15781577

@@ -1877,9 +1876,6 @@ bool CChainState::ConnectBlock(const CBlock& block, BlockValidationState& state,
18771876
int64_t nTime5 = GetTimeMicros(); nTimeIndex += nTime5 - nTime4;
18781877
LogPrint(BCLog::BENCH, " - Index writing: %.2fms [%.2fs (%.2fms/blk)]\n", MILLI * (nTime5 - nTime4), nTimeIndex * MICRO, nTimeIndex * MILLI / nBlocksTotal);
18791878

1880-
int64_t nTime6 = GetTimeMicros(); nTimeCallbacks += nTime6 - nTime5;
1881-
LogPrint(BCLog::BENCH, " - Callbacks: %.2fms [%.2fs (%.2fms/blk)]\n", MILLI * (nTime6 - nTime5), nTimeCallbacks * MICRO, nTimeCallbacks * MILLI / nBlocksTotal);
1882-
18831879
TRACE7(validation, block_connected,
18841880
block.GetHash().ToString().c_str(),
18851881
pindex->nHeight,

0 commit comments

Comments
 (0)