refactor: use const reference for parents in CTxMemPool::UpdateAncestorsOf

theStack · theStack · commit 9947ce62626c · 2021-10-07T01:47:14.000+02:00
diff --git a/src/txmempool.cpp b/src/txmempool.cpp
@@ -276,7 +276,7 @@ bool CTxMemPool::CalculateMemPoolAncestors(const CTxMemPoolEntry &entry,
 
 void CTxMemPool::UpdateAncestorsOf(bool add, txiter it, setEntries &setAncestors)
 {
-    CTxMemPoolEntry::Parents parents = it->GetMemPoolParents();
+    const CTxMemPoolEntry::Parents& parents = it->GetMemPoolParentsConst();
     // add or remove this tx as a child of each parent
     for (const CTxMemPoolEntry& parent : parents) {
         UpdateChild(mapTx.iterator_to(parent), it, add);

Original file line number	Diff line number	Diff line change
`@@ -276,7 +276,7 @@ bool CTxMemPool::CalculateMemPoolAncestors(const CTxMemPoolEntry &entry,`
`276`	`276`
`277`	`277`	`void CTxMemPool::UpdateAncestorsOf(bool add, txiter it, setEntries &setAncestors)`
`278`	`278`	`{`
`279`		`- CTxMemPoolEntry::Parents parents = it->GetMemPoolParents();`
	`279`	`+ const CTxMemPoolEntry::Parents& parents = it->GetMemPoolParentsConst();`
`280`	`280`	`// add or remove this tx as a child of each parent`
`281`	`281`	`for (const CTxMemPoolEntry& parent : parents) {`
`282`	`282`	`UpdateChild(mapTx.iterator_to(parent), it, add);`