Skip to content

Commit 999923e

Browse files
author
MarcoFalke
committed
[qa] util: Check return code after closing bitcoind proc
This has no effect on the outcome of test cases, but prints shorter and less confusing tracebacks on fails. I.e. does not print an obvious "ConnectionRefusedError" when shutting down the nodes due to an invalid return code.
1 parent 643fa0b commit 999923e

File tree

1 file changed

+1
-1
lines changed
  • test/functional/test_framework

1 file changed

+1
-1
lines changed

test/functional/test_framework/util.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -300,8 +300,8 @@ def _stop_node(node, i):
300300
except http.client.CannotSendRequest as e:
301301
logger.exception("Unable to stop node")
302302
return_code = bitcoind_processes[i].wait(timeout=BITCOIND_PROC_WAIT_TIMEOUT)
303-
assert_equal(return_code, 0)
304303
del bitcoind_processes[i]
304+
assert_equal(return_code, 0)
305305

306306
def _stop_nodes(nodes):
307307
"""Stop multiple bitcoind test nodes

0 commit comments

Comments
 (0)