Skip to content

Commit 9df1906

Browse files
committed
Merge bitcoin/bitcoin#22511: guix: Silence getent(1) invocation, doc fixups
a884a1e guix/INSTALL: Misc fixups (Carl Dong) 3c4d2c4 guix: Silence getent(1) invocation (Carl Dong) Pull request description: Otherwise the `getent(1)` checks will print out the default http, https, and ftp ports, making it seem like something is being spawned that is listening on those ports, which is not the case. ACKs for top commit: fanquake: ACK a884a1e Tree-SHA512: 7706a98fe5f2bcd766fd3a16bfffab899ec45e80d72c485b7bed2a83d2024eddbb44ae4a77e2352e308740ca203c163421a11a5a2327fa94d2032ecceef4d63f
2 parents e8b7b60 + a884a1e commit 9df1906

File tree

2 files changed

+8
-20
lines changed

2 files changed

+8
-20
lines changed

contrib/guix/INSTALL.md

Lines changed: 7 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -79,8 +79,8 @@ Guix v1.2.0 is available as a distribution package starting in [Debian
7979
21.04](https://packages.ubuntu.com/hirsute/guix).
8080

8181
Note that if you intend on using Guix without using any substitutes (more
82-
details [here][security-model]), v1.2.0 has a known problems when building
83-
GnuTLS from source. Solutions and workarounds are documented
82+
details [here][security-model]), v1.2.0 has a known problem when building GnuTLS
83+
from source. Solutions and workarounds are documented
8484
[here](#gnutls-test-suite-fail-status-request-revoked).
8585

8686

@@ -124,7 +124,7 @@ particular commit of Guix). Previous experience with using autotools-style build
124124
systems to build packages from source will be helpful. *hic sunt dracones.*
125125

126126
I strongly urge you to at least skim through the entire section once before you
127-
start issuing commands, as it will save you a lot of unncessary pain and
127+
start issuing commands, as it will save you a lot of unnecessary pain and
128128
anguish.
129129

130130
### Installing common build tools
@@ -165,7 +165,7 @@ packaged and installable without manually building and installing.
165165

166166
For reference, the graphic below outlines Guix v1.3.0's dependency graph:
167167

168-
![boostrap map](https://user-images.githubusercontent.com/6399679/125064185-a9a59880-e0b0-11eb-82c1-9b8e5dc9950d.png)
168+
![bootstrap map](https://user-images.githubusercontent.com/6399679/125064185-a9a59880-e0b0-11eb-82c1-9b8e5dc9950d.png)
169169

170170
#### Guile
171171

@@ -270,23 +270,11 @@ Note that these environment variables are used to check for packages during
270270
`./configure`, so they should be set as soon as possible should you want to use
271271
a prefix other than `/usr`.
272272

273-
<!-- ##### Example: Consistently using Guile 3.0 on Ubuntu -->
274-
275-
<!-- For example, on Ubuntu, if you choose to use Guile 3.0 and install the -->
276-
<!-- `guile-3.0` package, you want to make sure that if you also want to install the -->
277-
<!-- `guile-git` package with `apt` that said `guile-git` package was built for Guile -->
278-
<!-- v3.0. This can be checked by invoking the following: -->
279-
280-
<!-- ``` -->
281-
<!-- apt update -->
282-
<!-- apt show guile-git -->
283-
<!-- ``` -->
284-
285273
#### Building and installing source-built packages
286274

287-
***IMPORTANT**: A few dependencies have non-obvious quirks/erratas which are documented in the
288-
sub-sections immediately below. Please read these sections before proceeding to
289-
build and install these packages.*
275+
***IMPORTANT**: A few dependencies have non-obvious quirks/errata which are
276+
documented in the sub-sections immediately below. Please read these sections
277+
before proceeding to build and install these packages.*
290278

291279
Although you should always refer to the README or INSTALL files for the most
292280
accurate information, most of these dependencies use autoconf-style build

contrib/guix/guix-build

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,7 @@ fi
190190
# Services database must have basic entries
191191
################
192192

193-
if ! getent services http https ftp; then
193+
if ! getent services http https ftp > /dev/null 2>&1; then
194194
cat << EOF
195195
ERR: Your system's C library can not find service database entries for at least
196196
one of the following services: http, https, ftp.

0 commit comments

Comments
 (0)