Skip to content

Commit a1fe944

Browse files
committed
Remove reference to nonexistent "version" wallet transaction mapvalue field
This change removes a mapValue.erase("version") statement which deletes a mapValue entry that never existed. The statement was mistakenly added in commit 865c3a2 in 2010 and is harmless but confusing.
1 parent 654e044 commit a1fe944

File tree

1 file changed

+0
-5
lines changed

1 file changed

+0
-5
lines changed

src/wallet/wallet.h

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -268,10 +268,6 @@ class CWalletTx : public CMerkleTx
268268
* "timesmart" - serialized nTimeSmart value
269269
* "spent" - serialized vfSpent value that existed prior to
270270
* 2014 (removed in commit 93a18a3)
271-
*
272-
* A mapValue.erase("version") statement also appears in the code,
273-
* originating from commit 865c3a2 in 2010, but it does not appear that any
274-
* "version" entries were actually ever created by any version of bitcoin.
275271
*/
276272
mapValue_t mapValue;
277273
std::vector<std::pair<std::string, std::string> > vOrderForm;
@@ -381,7 +377,6 @@ class CWalletTx : public CMerkleTx
381377
}
382378

383379
mapValue.erase("fromaccount");
384-
mapValue.erase("version");
385380
mapValue.erase("spent");
386381
mapValue.erase("n");
387382
mapValue.erase("timesmart");

0 commit comments

Comments
 (0)