Skip to content

Commit a259453

Browse files
committed
Merge #17250: Avoid unused call to GuessVerificationProgress in NotifyHeaderTip
fa39809 Avoid unused call to GuessVerificationProgress in NotifyHeaderTip (MarcoFalke) Pull request description: `GuessVerificationProgress` for a header (not a block) is always 0 because the number of txs in the block can not be determined from the header alone. Anyway, this result was never used, so we can optimize this call by hardcoding 0. This is the next commit in a series of changes toward removing nChainTx (see #14863, #13875) ACKs for top commit: promag: Code review ACK fa39809, missed that. laanwj: ACK fa39809 Tree-SHA512: 11016f8dbb1af1cf75241948d1ad35eac0c79d1311cd0db8c6ec806df2a9e3dc5f998dbd66ccbad5d84564e6cec7fe21ce7a2a13c2b34c746e2d3b31aa1db53a
2 parents 9ae468a + fa39809 commit a259453

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/interfaces/node.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -312,7 +312,7 @@ class NodeImpl : public Node
312312
return MakeHandler(
313313
::uiInterface.NotifyHeaderTip_connect([fn](bool initial_download, const CBlockIndex* block) {
314314
fn(initial_download, block->nHeight, block->GetBlockTime(),
315-
GuessVerificationProgress(Params().TxData(), block));
315+
/* verification progress is unused when a header was received */ 0);
316316
}));
317317
}
318318
InitInterfaces m_interfaces;

0 commit comments

Comments
 (0)