miniscript: add a missing dup key check bypass in Parse()

darosior · darosior · commit a3793f2d1a43 · 2023-10-08T02:43:13.000+02:00
This was calling the wrong constructor.
diff --git a/src/script/miniscript.h b/src/script/miniscript.h
@@ -1727,7 +1727,7 @@ inline NodeRef<Key> Parse(Span<const char> in, const Ctx& ctx)
         case ParseContext::AND_N: {
             auto mid = std::move(constructed.back());
             constructed.pop_back();
-            constructed.back() = MakeNodeRef<Key>(internal::NoDupCheck{}, Fragment::ANDOR, Vector(std::move(constructed.back()), std::move(mid), MakeNodeRef<Key>(ctx, Fragment::JUST_0)));
+            constructed.back() = MakeNodeRef<Key>(internal::NoDupCheck{}, Fragment::ANDOR, Vector(std::move(constructed.back()), std::move(mid), MakeNodeRef<Key>(internal::NoDupCheck{}, Fragment::JUST_0)));
             break;
         }
         case ParseContext::AND_V: {

Original file line number	Diff line number	Diff line change
`@@ -1727,7 +1727,7 @@ inline NodeRef<Key> Parse(Span<const char> in, const Ctx& ctx)`
`1727`	`1727`	`case ParseContext::AND_N: {`
`1728`	`1728`	`auto mid = std::move(constructed.back());`
`1729`	`1729`	`constructed.pop_back();`
`1730`		`- constructed.back() = MakeNodeRef<Key>(internal::NoDupCheck{}, Fragment::ANDOR, Vector(std::move(constructed.back()), std::move(mid), MakeNodeRef<Key>(ctx, Fragment::JUST_0)));`
	`1730`	`+ constructed.back() = MakeNodeRef<Key>(internal::NoDupCheck{}, Fragment::ANDOR, Vector(std::move(constructed.back()), std::move(mid), MakeNodeRef<Key>(internal::NoDupCheck{}, Fragment::JUST_0)));`
`1731`	`1731`	`break;`
`1732`	`1732`	`}`
`1733`	`1733`	`case ParseContext::AND_V: {`