Skip to content

Commit a4a279b

Browse files
committed
Merge #19617: doc: Clang 8 or later is required with FORCE_USE_SYSTEM_CLANG
e60ef21 doc: Clang 8 or later is required with FORCE_USE_SYSTEM_CLANG (fanquake) Pull request description: The usage of pragmas within the macOS SDK requires LLVM Clang 8. This is the same version as our prebuilt Clang, however the minimum is worth noting here as they may diverge and/or expert users might expect they could use an earlier version. If you compile depends using `FORCE_USE_SYSTEM_CLANG=1` and Clang 7 you'll see output like: ```bash In file included from kernel/qcore_mac_objc.mm:44: In file included from /bitcoin/depends/SDKs/Xcode-11.3.1-11C505-extracted-SDK-with-libcxx-headers/System/Library/Frameworks/AppKit.framework/Headers/NSText.h:9: In file included from /bitcoin/depends/SDKs/Xcode-11.3.1-11C505-extracted-SDK-with-libcxx-headers/System/Library/Frameworks/AppKit.framework/Headers/NSView.h:19: In file included from /bitcoin/depends/SDKs/Xcode-11.3.1-11C505-extracted-SDK-with-libcxx-headers/System/Library/Frameworks/AppKit.framework/Headers/NSResponder.h:10: /bitcoin/depends/SDKs/Xcode-11.3.1-11C505-extracted-SDK-with-libcxx-headers/System/Library/Frameworks/AppKit.framework/Headers/NSEvent.h:19:1: error: expected 'push' or 'pop' after '#pragma clang attribute' /bitcoin/depends/SDKs/Xcode-11.3.1-11C505-extracted-SDK-with-libcxx-headers/usr/include/os/availability.h:104:273: note: expanded from macro 'API_UNAVAILABLE_BEGIN' ...__API_UNAVAILABLE_BEGIN5, __API_UNAVAILABLE_BEGIN4, __API_UNAVAILABLE_BEGIN3, __API_UNAVAILABLE_BEGIN2, __API_UNAVAILABLE_BEGIN1, 0)(__VA_A... ^ fatal error: too many errors emitted, stopping now [-ferror-limit=] 20 errors generated. ``` I've got a [godbolt here](https://godbolt.org/z/j6r987) that contains a demo of the issue (based off the macOS SDK). It will compile with Clang 8 but not with Clang 7. ACKs for top commit: laanwj: ACK e60ef21 Tree-SHA512: affc082a4b28d9cd102a844e10f63f55f0f20a9f840e5d8037a41470ad1ea83edc3075ce262b1d618c59c9b75445e52ddd9ba9f84c5ac3da9ce20681473c47b1
2 parents edec7f7 + e60ef21 commit a4a279b

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

depends/README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -110,9 +110,9 @@ The following can be set when running make: `make FOO=bar`
110110
<dt>BUILD_ID_SALT</dt>
111111
<dd>Optional salt to use when generating build package ids</dd>
112112
<dt>FORCE_USE_SYSTEM_CLANG</dt>
113-
<dd>(EXPERTS ONLY) When cross-compiling for macOS, use clang found in the
114-
system's <code>$PATH</code> rather than the default prebuilt release of clang
115-
from llvm.org</dd>
113+
<dd>(EXPERTS ONLY) When cross-compiling for macOS, use Clang found in the
114+
system's <code>$PATH</code> rather than the default prebuilt release of Clang
115+
from llvm.org. Clang 8 or later is required.</dd>
116116
</dl>
117117

118118
If some packages are not built, for example `make NO_WALLET=1`, the appropriate

0 commit comments

Comments
 (0)