Skip to content

Commit a6a993a

Browse files
author
MarcoFalke
committed
Merge #20060: refactor: fix -Wbraced-scalar-init warning in validation tests
82b70f1 refactor: fix -Wbraced-scalar-init warning in validation tests (fanquake) Pull request description: Introduced in #20004 (fa29b5a). ``` test/validation_tests.cpp:68:88: warning: braces around scalar initializer [-Wbraced-scalar-init] BOOST_CHECK(signet_params->GetConsensus().signet_challenge == std::vector<uint8_t>{{OP_TRUE}}); ^~~~~~~~~ /usr/local/include/boost/test/tools/old/interface.hpp:83:6: note: expanded from macro 'BOOST_CHECK' (P), BOOST_TEST_STRINGIZE( P ), CHECK, CHECK_PRED, _ ) ^ /usr/local/include/boost/test/tools/old/interface.hpp:68:61: note: expanded from macro 'BOOST_TEST_TOOL_IMPL' BOOST_JOIN( BOOST_TEST_TOOL_PASS_PRED, frwd_type )( P, ARGS ), \ ^ /usr/local/include/boost/test/tools/old/interface.hpp:51:47: note: expanded from macro 'BOOST_TEST_TOOL_PASS_PRED2' ^ 1 warning generated. ``` ACKs for top commit: practicalswift: ACK 82b70f1 MarcoFalke: ACK 82b70f1 Tree-SHA512: ae14acd52e2a0d370a6ee7321f257190c6a44094eb3fa5a6bd85b6bb2b4002e7784589cb34dcf78545238c33cbea38113061b2a46e092f1119731e70932fa469
2 parents 69a7380 + 82b70f1 commit a6a993a

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/test/validation_tests.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ BOOST_AUTO_TEST_CASE(signet_parse_tests)
6565
signet_argsman.ForceSetArg("-signetchallenge", "51"); // set challenge to OP_TRUE
6666
const auto signet_params = CreateChainParams(signet_argsman, CBaseChainParams::SIGNET);
6767
CBlock block;
68-
BOOST_CHECK(signet_params->GetConsensus().signet_challenge == std::vector<uint8_t>{{OP_TRUE}});
68+
BOOST_CHECK(signet_params->GetConsensus().signet_challenge == std::vector<uint8_t>{OP_TRUE});
6969
CScript challenge{OP_TRUE};
7070

7171
// empty block is invalid

0 commit comments

Comments
 (0)