fuzz: Initialize a full TestingSetup where appropriate

dongcarl · dongcarl · commit abb6fa728598 · 2021-01-21T09:29:42.000-05:00
A full TestingSetup is required for both coins_view and
load_external_block_file as they interact with the active chainstate.
diff --git a/src/test/fuzz/coins_view.cpp b/src/test/fuzz/coins_view.cpp
@@ -36,9 +36,7 @@ bool operator==(const Coin& a, const Coin& b)
 
 void initialize_coins_view()
 {
-    static const ECCVerifyHandle ecc_verify_handle;
-    ECC_Start();
-    SelectParams(CBaseChainParams::REGTEST);
+    static const auto testing_setup = MakeFuzzingContext<const TestingSetup>();
 }
 
 FUZZ_TARGET_INIT(coins_view, initialize_coins_view)
diff --git a/src/test/fuzz/load_external_block_file.cpp b/src/test/fuzz/load_external_block_file.cpp
@@ -15,7 +15,7 @@
 
 void initialize_load_external_block_file()
 {
-    static const auto testing_setup = MakeFuzzingContext<>();
+    static const auto testing_setup = MakeFuzzingContext<const TestingSetup>();
 }
 
 FUZZ_TARGET_INIT(load_external_block_file, initialize_load_external_block_file)

Original file line number	Diff line number	Diff line change
`@@ -36,9 +36,7 @@ bool operator==(const Coin& a, const Coin& b)`
`36`	`36`
`37`	`37`	`void initialize_coins_view()`
`38`	`38`	`{`
`39`		`- static const ECCVerifyHandle ecc_verify_handle;`
`40`		`- ECC_Start();`
`41`		`- SelectParams(CBaseChainParams::REGTEST);`
	`39`	`+ static const auto testing_setup = MakeFuzzingContext<const TestingSetup>();`
`42`	`40`	`}`
`43`	`41`
`44`	`42`	`FUZZ_TARGET_INIT(coins_view, initialize_coins_view)`
Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,7 @@`
`15`	`15`
`16`	`16`	`void initialize_load_external_block_file()`
`17`	`17`	`{`
`18`		`- static const auto testing_setup = MakeFuzzingContext<>();`
	`18`	`+ static const auto testing_setup = MakeFuzzingContext<const TestingSetup>();`
`19`	`19`	`}`
`20`	`20`
`21`	`21`	`FUZZ_TARGET_INIT(load_external_block_file, initialize_load_external_block_file)`