Skip to content

Commit af4ce67

Browse files
committed
Merge #20635: fix misleading comment about call to non-existing function
cc3044c fix misleading comment about call to non-existing function (pox) Pull request description: The comment seems to be describing the subsequent call to `SyncTransaction` but refers to it as `SyncNotifications`, which is not any function currently in the codebase. It's best to just remove the "what" aspect of the comment and focus on the "why", which also reduces the risk of similar documentation errors in the future, in case the function ever gets renamed, for example. ACKs for top commit: laanwj: ACK cc3044c Tree-SHA512: 882ff17836ef585a603dc504f3dd21f56f682e49b28a0998f23fd16025826fbb083b7978db3ee70d0e0ff2c86fd6c3fd99a2361e5d45c765fdc5822c5f14c0a7
2 parents cfbfd38 + cc3044c commit af4ce67

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

src/wallet/wallet.cpp

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1178,9 +1178,8 @@ void CWallet::transactionRemovedFromMempool(const CTransactionRef& tx, MemPoolRe
11781178
// Handle transactions that were removed from the mempool because they
11791179
// conflict with transactions in a newly connected block.
11801180
if (reason == MemPoolRemovalReason::CONFLICT) {
1181-
// Call SyncNotifications, so external -walletnotify notifications will
1182-
// be triggered for these transactions. Set Status::UNCONFIRMED instead
1183-
// of Status::CONFLICTED for a few reasons:
1181+
// Trigger external -walletnotify notifications for these transactions.
1182+
// Set Status::UNCONFIRMED instead of Status::CONFLICTED for a few reasons:
11841183
//
11851184
// 1. The transactionRemovedFromMempool callback does not currently
11861185
// provide the conflicting block's hash and height, and for backwards

0 commit comments

Comments
 (0)