Skip to content

Commit af7e365

Browse files
hebastoryanofsky
andcommitted
qt: Make PACKAGE_BUGREPORT link clickable
Co-authored-by: Russell Yanofsky <[email protected]>
1 parent e658b0e commit af7e365

File tree

3 files changed

+20
-1
lines changed

3 files changed

+20
-1
lines changed

src/qt/bitcoin.cpp

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,10 +45,12 @@
4545
#include <QApplication>
4646
#include <QDebug>
4747
#include <QFontDatabase>
48+
#include <QLatin1String>
4849
#include <QLibraryInfo>
4950
#include <QLocale>
5051
#include <QMessageBox>
5152
#include <QSettings>
53+
#include <QStringBuilder>
5254
#include <QThread>
5355
#include <QTimer>
5456
#include <QTranslator>
@@ -417,7 +419,10 @@ void BitcoinApplication::shutdownResult()
417419

418420
void BitcoinApplication::handleRunawayException(const QString &message)
419421
{
420-
QMessageBox::critical(nullptr, "Runaway exception", BitcoinGUI::tr("A fatal error occurred. %1 can no longer continue safely and will quit.").arg(PACKAGE_NAME) + QString("<br><br>") + message);
422+
QMessageBox::critical(
423+
nullptr, tr("Runaway exception"),
424+
tr("A fatal error occurred. %1 can no longer continue safely and will quit.").arg(PACKAGE_NAME) %
425+
QLatin1String("<br><br>") % GUIUtil::MakeHtmlLink(message, PACKAGE_BUGREPORT));
421426
::exit(EXIT_FAILURE);
422427
}
423428

src/qt/guiutil.cpp

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@
4242
#include <QGuiApplication>
4343
#include <QJsonObject>
4444
#include <QKeyEvent>
45+
#include <QLatin1String>
4546
#include <QLineEdit>
4647
#include <QList>
4748
#include <QLocale>
@@ -54,6 +55,7 @@
5455
#include <QShortcut>
5556
#include <QSize>
5657
#include <QString>
58+
#include <QStringBuilder>
5759
#include <QTextDocument> // for Qt::mightBeRichText
5860
#include <QThread>
5961
#include <QUrlQuery>
@@ -893,4 +895,11 @@ QImage GetImage(const QLabel* label)
893895
#endif
894896
}
895897

898+
QString MakeHtmlLink(const QString& source, const QString& link)
899+
{
900+
return QString(source).replace(
901+
link,
902+
QLatin1String("<a href=\"") % link % QLatin1String("\">") % link % QLatin1String("</a>"));
903+
}
904+
896905
} // namespace GUIUtil

src/qt/guiutil.h

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -327,6 +327,11 @@ namespace GUIUtil
327327
QObject::connect(&source, &QObject::destroyed, object, std::forward<Fn>(function), connection);
328328
}
329329

330+
/**
331+
* Replaces a plain text link with an HTML tagged one.
332+
*/
333+
QString MakeHtmlLink(const QString& source, const QString& link);
334+
330335
} // namespace GUIUtil
331336

332337
#endif // BITCOIN_QT_GUIUTIL_H

0 commit comments

Comments
 (0)