refactor: Avoid recursive locking in CAddrMan::Clear

hebasto · jnewbery · hebasto · commit b138973a8b4b · 2021-06-14T17:28:37.000+03:00
Co-authored-by: John Newbery &lt;john@johnnewbery.com&gt;
diff --git a/src/addrman.h b/src/addrman.h
@@ -299,7 +299,7 @@ class CAddrMan
     {
         LOCK(cs);
 
-        Clear();
+        assert(vRandom.empty());
 
         Format format;
         s_ >> Using<CustomUintFormatter<1>>(format);

Original file line number	Diff line number	Diff line change
`@@ -299,7 +299,7 @@ class CAddrMan`
`299`	`299`	`{`
`300`	`300`	`LOCK(cs);`
`301`	`301`
`302`		`- Clear();`
	`302`	`+ assert(vRandom.empty());`
`303`	`303`
`304`	`304`	`Format format;`
`305`	`305`	`s_ >> Using<CustomUintFormatter<1>>(format);`