net: Use network byte order for in_addr.s_addr

hebasto · hebasto · commit b3273cf4039d · 2020-09-29T09:59:43.000+03:00
It is documented in the ip(7) manual page.
diff --git a/src/net.cpp b/src/net.cpp
@@ -2322,7 +2322,7 @@ bool CConnman::InitBinds(const std::vector<CService>& binds, const std::vector<N
     }
     if (binds.empty() && whiteBinds.empty()) {
         struct in_addr inaddr_any;
-        inaddr_any.s_addr = INADDR_ANY;
+        inaddr_any.s_addr = htonl(INADDR_ANY);
         struct in6_addr inaddr6_any = IN6ADDR_ANY_INIT;
         fBound |= Bind(CService(inaddr6_any, GetListenPort()), BF_NONE, NetPermissionFlags::PF_NONE);
         fBound |= Bind(CService(inaddr_any, GetListenPort()), !fBound ? BF_REPORT_ERROR : BF_NONE, NetPermissionFlags::PF_NONE);

Original file line number	Diff line number	Diff line change
`@@ -2322,7 +2322,7 @@ bool CConnman::InitBinds(const std::vector<CService>& binds, const std::vector<N`
`2322`	`2322`	`}`
`2323`	`2323`	`if (binds.empty() && whiteBinds.empty()) {`
`2324`	`2324`	`struct in_addr inaddr_any;`
`2325`		`- inaddr_any.s_addr = INADDR_ANY;`
	`2325`	`+ inaddr_any.s_addr = htonl(INADDR_ANY);`
`2326`	`2326`	`struct in6_addr inaddr6_any = IN6ADDR_ANY_INIT;`
`2327`	`2327`	`fBound \|= Bind(CService(inaddr6_any, GetListenPort()), BF_NONE, NetPermissionFlags::PF_NONE);`
`2328`	`2328`	`fBound \|= Bind(CService(inaddr_any, GetListenPort()), !fBound ? BF_REPORT_ERROR : BF_NONE, NetPermissionFlags::PF_NONE);`