Merge #18917: fuzz: fix vector size problem in system fuzzer

MarcoFalke · MarcoFalke · commit b55866969e24 · 2020-05-08T18:11:43.000-04:00
095bc9a fuzz: fix vector size problem in system fuzzer (Harris) Pull request description: This PR fixes a problem with vector resizing in system fuzzer (*case 7* there). Originally, this problem was discussed in PR bitcoin/bitcoin#18908 ACKs for top commit: MarcoFalke: ACK 095bc9a practicalswift: ACK 095bc9a brakmic: > ACK [095bc9a](bitcoin/bitcoin@095bc9a) Tree-SHA512: 73e6004ee51d68a34b49c79d1329a8c4865c21da888801c0fcc7f1bcacb510bf371bb61675eda83e53d08e0f24712e671369719523b0ced0eb2a22607bfa1d3d
diff --git a/src/test/fuzz/system.cpp b/src/test/fuzz/system.cpp
@@ -85,7 +85,7 @@ void test_one_input(const std::vector<uint8_t>& buffer)
         case 7: {
             const std::vector<std::string> random_arguments = ConsumeRandomLengthStringVector(fuzzed_data_provider);
             std::vector<const char*> argv;
-            argv.resize(random_arguments.size());
+            argv.reserve(random_arguments.size());
             for (const std::string& random_argument : random_arguments) {
                 argv.push_back(random_argument.c_str());
             }

Original file line number	Diff line number	Diff line change
`@@ -85,7 +85,7 @@ void test_one_input(const std::vector<uint8_t>& buffer)`
`85`	`85`	`case 7: {`
`86`	`86`	`const std::vector<std::string> random_arguments = ConsumeRandomLengthStringVector(fuzzed_data_provider);`
`87`	`87`	`std::vector<const char*> argv;`
`88`		`- argv.resize(random_arguments.size());`
	`88`	`+ argv.reserve(random_arguments.size());`
`89`	`89`	`for (const std::string& random_argument : random_arguments) {`
`90`	`90`	`argv.push_back(random_argument.c_str());`
`91`	`91`	`}`