Merge #19593: refactor: Drop unused CBufferedFile::Seek()

7b3851e refactor: Drop unused CBufferedFile::Seek() (Hennadii Stepanov)

Pull request description:

ACKs for top commit:
  practicalswift:
    ACK 7b3851e -- deleted code is better than unused untested code:)
  MarcoFalke:
    ACK 7b3851e, assuming that removing this should either be correct or result in a compile failure
  jonasschnelli:
    utACK 7b3851e
  promag:
    Code review ACK 7b3851e.

Tree-SHA512: 7bfd172aa4bbe349855c1303fd9cd58093d66833fefe46bd29081bfcca4ab434b84c6b84e76e94d06b8749a5abe1dc1e184f5189136cd1403d0e5bc25ad6d456

Author: laanwj

src/streams.h

@@ -814,18 +814,6 @@ class CBufferedFile
         return true;
     }
 
-    bool Seek(uint64_t nPos) {
-        long nLongPos = nPos;
-        if (nPos != (uint64_t)nLongPos)
-            return false;
-        if (fseek(src, nLongPos, SEEK_SET))
-            return false;
-        nLongPos = ftell(src);
-        nSrcPos = nLongPos;
-        nReadPos = nLongPos;
-        return true;
-    }
-
     //! prevent reading beyond a certain position
     //! no argument removes the limit
     bool SetLimit(uint64_t nPos = std::numeric_limits<uint64_t>::max()) {

src/test/fuzz/buffered_file.cpp

@@ -31,7 +31,7 @@ void test_one_input(const std::vector<uint8_t>& buffer)
     if (opt_buffered_file && fuzzed_file != nullptr) {
         bool setpos_fail = false;
         while (fuzzed_data_provider.ConsumeBool()) {
-            switch (fuzzed_data_provider.ConsumeIntegralInRange<int>(0, 5)) {
+            switch (fuzzed_data_provider.ConsumeIntegralInRange<int>(0, 4)) {
             case 0: {
                 std::array<uint8_t, 4096> arr{};
                 try {
@@ -41,20 +41,16 @@ void test_one_input(const std::vector<uint8_t>& buffer)
                 break;
             }
             case 1: {
-                opt_buffered_file->Seek(fuzzed_data_provider.ConsumeIntegralInRange<uint64_t>(0, 4096));
-                break;
-            }
-            case 2: {
                 opt_buffered_file->SetLimit(fuzzed_data_provider.ConsumeIntegralInRange<uint64_t>(0, 4096));
                 break;
             }
-            case 3: {
+            case 2: {
                 if (!opt_buffered_file->SetPos(fuzzed_data_provider.ConsumeIntegralInRange<uint64_t>(0, 4096))) {
                     setpos_fail = true;
                 }
                 break;
             }
-            case 4: {
+            case 3: {
                 if (setpos_fail) {
                     // Calling FindByte(...) after a failed SetPos(...) call may result in an infinite loop.
                     break;
@@ -65,7 +61,7 @@ void test_one_input(const std::vector<uint8_t>& buffer)
                 }
                 break;
             }
-            case 5: {
+            case 4: {
                 ReadFromStream(fuzzed_data_provider, *opt_buffered_file);
                 break;
             }