Skip to content

Commit b997dd2

Browse files
committed
Merge bitcoin/bitcoin#22809: test: Check that non-signaling BIP125 tx can be replaced via parent
fa2e9de test: Check that non-signaling BIP125 tx can be replaced via parent (MarcoFalke) Pull request description: While `optout_child_tx` in the `test_no_inherited_signaling` test is reported as "bip125-replaceable", it is not *directly* replaceable. For example by bumping the fee of `optout_child_tx`. However, it is still replaceable *indirectly* via it's BIP-125 signalling parent. Clarify this by extending the test. ACKs for top commit: mjdietzx: Tested ACK fa2e9de josibake: ACK bitcoin/bitcoin@fa2e9de Tree-SHA512: b3608beae743dcb6152df4d2cfe1c0af6b4404ba3837f73e1d1431bd7c637f0c7fab0379aaab2218d5cd63e71070a079c0595ec031056058e8d3c933c2bae0a9
2 parents 245462b + fa2e9de commit b997dd2

File tree

1 file changed

+11
-0
lines changed

1 file changed

+11
-0
lines changed

test/functional/feature_rbf.py

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -618,6 +618,17 @@ def test_no_inherited_signaling(self):
618618
assert_equal(True, self.nodes[0].getmempoolentry(optin_parent_tx['txid'])['bip125-replaceable'])
619619
assert_raises_rpc_error(-26, 'txn-mempool-conflict', self.nodes[0].sendrawtransaction, replacement_child_tx["hex"], 0)
620620

621+
self.log.info('Check that the child tx can still be replaced (via a tx that also replaces the parent)')
622+
replacement_parent_tx = self.wallet.send_self_transfer(
623+
from_node=self.nodes[0],
624+
utxo_to_spend=confirmed_utxo,
625+
sequence=0xffffffff,
626+
fee_rate=Decimal('0.03'),
627+
)
628+
# Check that child is removed and update wallet utxo state
629+
assert_raises_rpc_error(-5, 'Transaction not in mempool', self.nodes[0].getmempoolentry, optout_child_tx['txid'])
630+
self.wallet.get_utxo(txid=optout_child_tx['txid'])
631+
621632
def test_replacement_relay_fee(self):
622633
tx = self.wallet.send_self_transfer(from_node=self.nodes[0])['tx']
623634

0 commit comments

Comments
 (0)