Directly abort execution in FeeBumper::commit if wallet or tx is not available

jonasschnelli · jonasschnelli · commit bcc72cccc72f · 2017-04-02T10:12:42.000+02:00
diff --git a/src/wallet/feebumper.cpp b/src/wallet/feebumper.cpp
@@ -236,6 +236,7 @@ bool CFeeBumper::commit(CWallet *pWallet)
     if (txid.IsNull() || !pWallet->mapWallet.count(txid)) {
         vErrors.push_back("Invalid or non-wallet transaction id");
         currentResult = BumpFeeResult::MISC_ERROR;
+        return false;
     }
     CWalletTx& oldWtx = pWallet->mapWallet[txid];
 

Original file line number	Diff line number	Diff line change
`@@ -236,6 +236,7 @@ bool CFeeBumper::commit(CWallet *pWallet)`
`236`	`236`	`if (txid.IsNull() \|\| !pWallet->mapWallet.count(txid)) {`
`237`	`237`	`vErrors.push_back("Invalid or non-wallet transaction id");`
`238`	`238`	`currentResult = BumpFeeResult::MISC_ERROR;`
	`239`	`+ return false;`
`239`	`240`	`}`
`240`	`241`	`CWalletTx& oldWtx = pWallet->mapWallet[txid];`
`241`	`242`