Add linting of WalletLogPrintf(...) format strings

practicalswift · practicalswift · commit bcd4b0f5cdde · 2018-08-07T14:57:54.000+02:00
diff --git a/test/lint/lint-format-strings.py b/test/lint/lint-format-strings.py
@@ -18,6 +18,8 @@
     ("src/netbase.cpp", "LogConnectFailure(bool manual_connection, const char* fmt, const Args&... args)"),
     ("src/util.cpp", "strprintf(_(COPYRIGHT_HOLDERS), _(COPYRIGHT_HOLDERS_SUBSTITUTION))"),
     ("src/util.cpp", "strprintf(COPYRIGHT_HOLDERS, COPYRIGHT_HOLDERS_SUBSTITUTION)"),
+    ("src/wallet/wallet.h",  "WalletLogPrintf(std::string fmt, Params... parameters)"),
+    ("src/wallet/wallet.h", "LogPrintf((\"%s \" + fmt).c_str(), GetDisplayName(), parameters...)"),
 ]
 
 
diff --git a/test/lint/lint-format-strings.sh b/test/lint/lint-format-strings.sh
@@ -24,6 +24,7 @@ FUNCTION_NAMES_AND_NUMBER_OF_LEADING_ARGUMENTS=(
     vprintf,1
     vsnprintf,1
     vsprintf,1
+    WalletLogPrintf,0
 )
 
 EXIT_CODE=0

Original file line number	Diff line number	Diff line change
`@@ -18,6 +18,8 @@`
`18`	`18`	`("src/netbase.cpp", "LogConnectFailure(bool manual_connection, const char* fmt, const Args&... args)"),`
`19`	`19`	`("src/util.cpp", "strprintf(_(COPYRIGHT_HOLDERS), _(COPYRIGHT_HOLDERS_SUBSTITUTION))"),`
`20`	`20`	`("src/util.cpp", "strprintf(COPYRIGHT_HOLDERS, COPYRIGHT_HOLDERS_SUBSTITUTION)"),`
	`21`	`+ ("src/wallet/wallet.h", "WalletLogPrintf(std::string fmt, Params... parameters)"),`
	`22`	`+ ("src/wallet/wallet.h", "LogPrintf((\"%s \" + fmt).c_str(), GetDisplayName(), parameters...)"),`
`21`	`23`	`]`
`22`	`24`
`23`	`25`
Original file line number	Diff line number	Diff line change
`@@ -24,6 +24,7 @@ FUNCTION_NAMES_AND_NUMBER_OF_LEADING_ARGUMENTS=(`
`24`	`24`	`vprintf,1`
`25`	`25`	`vsnprintf,1`
`26`	`26`	`vsprintf,1`
	`27`	`+ WalletLogPrintf,0`
`27`	`28`	`)`
`28`	`29`
`29`	`30`	`EXIT_CODE=0`