Skip to content

Commit be7555f

Browse files
TheBlueMattsipa
authored andcommitted
Fix overly-prescriptive p2p-segwit test for new fetch logic
1 parent 06128da commit be7555f

File tree

1 file changed

+1
-9
lines changed

1 file changed

+1
-9
lines changed

qa/rpc-tests/p2p-segwit.py

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -912,14 +912,6 @@ def test_witness_tx_relay_before_segwit_activation(self):
912912
# But eliminating the witness should fix it
913913
self.test_node.test_transaction_acceptance(tx, with_witness=False, accepted=True)
914914

915-
# Verify that inv's to test_node come with getdata's for non-witness tx's
916-
# Just tweak the transaction, announce it, and verify we get a getdata
917-
# for a normal tx
918-
tx.vout[0].scriptPubKey = CScript([OP_TRUE, OP_TRUE])
919-
tx.rehash()
920-
self.test_node.announce_tx_and_wait_for_getdata(tx)
921-
assert(self.test_node.last_getdata.inv[0].type == 1)
922-
923915
# Cleanup: mine the first transaction and update utxo
924916
self.nodes[0].generate(1)
925917
assert_equal(len(self.nodes[0].getrawmempool()), 0)
@@ -1025,7 +1017,7 @@ def test_tx_relay_after_segwit_activation(self):
10251017
def test_block_relay(self, segwit_activated):
10261018
print("\tTesting block relay")
10271019

1028-
blocktype = 2|MSG_WITNESS_FLAG if segwit_activated else 2
1020+
blocktype = 2|MSG_WITNESS_FLAG
10291021

10301022
# test_node has set NODE_WITNESS, so all getdata requests should be for
10311023
# witness blocks.

0 commit comments

Comments
 (0)