Skip to content

Commit c008526

Browse files
author
MarcoFalke
committed
Merge bitcoin-core#254: refactor: Drop redundant setEditTriggers(NoEditTriggers) calls
257f55c qt, refactor: Drop redundant setEditTriggers(NoEditTriggers) calls (Hennadii Stepanov) Pull request description: The models of the both views have no `Qt::ItemIsEditable` flag: https://github.com/bitcoin-core/gui/blob/3c87dbe95c925274f80234ad4a88beb5a05fdfff/src/qt/peertablemodel.cpp#L218-L224 https://github.com/bitcoin-core/gui/blob/3c87dbe95c925274f80234ad4a88beb5a05fdfff/src/qt/bantablemodel.cpp#L148-L154 ACKs for top commit: Talkless: utACK 257f55c, seems reasonable. jarolrod: ACK 257f55c, looks correct. Tree-SHA512: 4356e4d785055935fba452488a5d97ed95995def97b26ab18af43a545835f9e9d4c347e4cad7952aa725179cf6e775a2208c48730feebf40e3b1a7ba5f402af0
2 parents e658b0e + 257f55c commit c008526

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

src/qt/rpcconsole.cpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -608,7 +608,6 @@ void RPCConsole::setClientModel(ClientModel *model, int bestblock_height, int64_
608608
// set up peer table
609609
ui->peerWidget->setModel(model->getPeerTableModel());
610610
ui->peerWidget->verticalHeader()->hide();
611-
ui->peerWidget->setEditTriggers(QAbstractItemView::NoEditTriggers);
612611
ui->peerWidget->setSelectionBehavior(QAbstractItemView::SelectRows);
613612
ui->peerWidget->setSelectionMode(QAbstractItemView::ExtendedSelection);
614613
ui->peerWidget->setContextMenuPolicy(Qt::CustomContextMenu);
@@ -651,7 +650,6 @@ void RPCConsole::setClientModel(ClientModel *model, int bestblock_height, int64_
651650
// set up ban table
652651
ui->banlistWidget->setModel(model->getBanTableModel());
653652
ui->banlistWidget->verticalHeader()->hide();
654-
ui->banlistWidget->setEditTriggers(QAbstractItemView::NoEditTriggers);
655653
ui->banlistWidget->setSelectionBehavior(QAbstractItemView::SelectRows);
656654
ui->banlistWidget->setSelectionMode(QAbstractItemView::SingleSelection);
657655
ui->banlistWidget->setContextMenuPolicy(Qt::CustomContextMenu);

0 commit comments

Comments
 (0)