Skip to content

Commit c90ce0f

Browse files
committed
Merge #17022: doc: move-only: Steps for "before major release branch-off"
faca1c2 doc: move-only: Steps for "before major release branch-off" (MarcoFalke) Pull request description: The chainparams are updated before branch-off, so that the master branch has the bumped values as well ACKs for top commit: laanwj: ACK faca1c2 Tree-SHA512: ffc3ea49f0f6dc64dd9bea958e12ebc058496291c1c06d02994b3bf1751602e7c5000fd5eda166fcdbf9ba6d593e19731e93342dd8f2fe410f656a798bef459c
2 parents 4715037 + faca1c2 commit c90ce0f

File tree

1 file changed

+10
-10
lines changed

1 file changed

+10
-10
lines changed

doc/release-process.md

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -14,19 +14,9 @@ Release Process
1414
* Update [bips.md](bips.md) to account for changes since the last release (don't forget to bump the version number on the first line).
1515
* Update version in `configure.ac` (don't forget to set `CLIENT_VERSION_RC` to `0`).
1616
* Write release notes (see "Write the release notes" below).
17-
* Update `src/chainparams.cpp` nMinimumChainWork with information from the getblockchaininfo rpc.
18-
* Update `src/chainparams.cpp` defaultAssumeValid with information from the getblockhash rpc.
19-
- The selected value must not be orphaned so it may be useful to set the value two blocks back from the tip.
20-
- Testnet should be set some tens of thousands back from the tip due to reorgs there.
21-
- This update should be reviewed with a reindex-chainstate with assumevalid=0 to catch any defect
22-
that causes rejection of blocks in the past history.
2317

2418
### Before every major release
2519

26-
* Update hardcoded [seeds](/contrib/seeds/README.md), see [this pull request](https://github.com/bitcoin/bitcoin/pull/7415) for an example.
27-
* Update [`src/chainparams.cpp`](/src/chainparams.cpp) m_assumed_blockchain_size and m_assumed_chain_state_size with the current size plus some overhead (see [this](#how-to-calculate-m_assumed_blockchain_size-and-m_assumed_chain_state_size) for information on how to calculate them).
28-
* Update `src/chainparams.cpp` chainTxData with statistics about the transaction count and rate. Use the output of the RPC `getchaintxstats`, see
29-
[this pull request](https://github.com/bitcoin/bitcoin/pull/17002) for an example. Reviewers can verify the results by running `getchaintxstats <window_block_count> <window_last_block_hash>` with the `window_block_count` and `window_last_block_hash` from your output.
3020
* On both the master branch and the new release branch:
3121
- update `CLIENT_VERSION_MINOR` in [`configure.ac`](../configure.ac)
3222
- update `CLIENT_VERSION_MINOR`, `PACKAGE_VERSION`, and `PACKAGE_STRING` in [`build_msvc/bitcoin_config.h`](/build_msvc/bitcoin_config.h)
@@ -36,6 +26,16 @@ Release Process
3626

3727
#### Before branch-off
3828

29+
* Update hardcoded [seeds](/contrib/seeds/README.md), see [this pull request](https://github.com/bitcoin/bitcoin/pull/7415) for an example.
30+
* Update [`src/chainparams.cpp`](/src/chainparams.cpp) m_assumed_blockchain_size and m_assumed_chain_state_size with the current size plus some overhead (see [this](#how-to-calculate-m_assumed_blockchain_size-and-m_assumed_chain_state_size) for information on how to calculate them).
31+
* Update `src/chainparams.cpp` chainTxData with statistics about the transaction count and rate. Use the output of the RPC `getchaintxstats`, see
32+
[this pull request](https://github.com/bitcoin/bitcoin/pull/17002) for an example. Reviewers can verify the results by running `getchaintxstats <window_block_count> <window_last_block_hash>` with the `window_block_count` and `window_last_block_hash` from your output.
33+
* Update `src/chainparams.cpp` nMinimumChainWork with information from the getblockchaininfo rpc.
34+
* Update `src/chainparams.cpp` defaultAssumeValid with information from the getblockhash rpc.
35+
- The selected value must not be orphaned so it may be useful to set the value two blocks back from the tip.
36+
- Testnet should be set some tens of thousands back from the tip due to reorgs there.
37+
- This update should be reviewed with a reindex-chainstate with assumevalid=0 to catch any defect
38+
that causes rejection of blocks in the past history.
3939
- Clear the release notes and move them to the wiki (see "Write the release notes" below).
4040

4141
#### After branch-off (on master)

0 commit comments

Comments
 (0)