node/chainstate: Decouple from GetTimeMillis

...instead just move it out

Author: dongcarl

src/init.cpp

@@ -1419,6 +1419,7 @@ bool AppInitMain(NodeContext& node, interfaces::BlockAndHeaderTipInfo* tip_info)
 
         uiInterface.InitMessage(_("Loading block index…").translated);
 
+        const int64_t load_block_index_start_time = GetTimeMillis();
         bool rv = LoadChainstate(fLoaded,
                                  strLoadError,
                                  fReset,
@@ -1432,6 +1433,9 @@ bool AppInitMain(NodeContext& node, interfaces::BlockAndHeaderTipInfo* tip_info)
                                  nCoinDBCache,
                                  nCoinCacheUsage);
         if (!rv) return false;
+        if (fLoaded) {
+            LogPrintf(" block index %15dms\n", GetTimeMillis() - load_block_index_start_time);
+        }
 
         if (!fLoaded && !ShutdownRequested()) {
             // first suggest a reindex

src/node/chainstate.cpp

@@ -6,7 +6,7 @@
 
 #include <chainparams.h> // for CChainParams
 #include <rpc/blockchain.h> // for RPCNotifyBlockChange
-#include <util/time.h> // for GetTime, GetTimeMillis
+#include <util/time.h> // for GetTime
 #include <util/translation.h> // for bilingual_str
 #include <node/blockstorage.h> // for CleanupBlockRevFiles, fHavePruned, fReindex
 #include <node/context.h> // for NodeContext
@@ -31,7 +31,6 @@ bool LoadChainstate(bool& fLoaded,
     };
 
     do {
-        const int64_t load_block_index_start_time = GetTimeMillis();
         try {
             LOCK(cs_main);
             chainman.InitializeChainstate(Assert(node.mempool.get()));
@@ -197,7 +196,6 @@ bool LoadChainstate(bool& fLoaded,
 
         if (!failed_verification) {
             fLoaded = true;
-            LogPrintf(" block index %15dms\n", GetTimeMillis() - load_block_index_start_time);
         }
     } while(false);
     return true;