Skip to content

Commit cc7ad2f

Browse files
author
MarcoFalke
committed
Merge #15013: test: Avoid race in p2p_timeouts
fabcd64 test: Avoid racy test p2p_timeouts (MarcoFalke) Pull request description: Avoid filesystem/network racyness by sleeping another second. The alternative would be to poll the `debug.log`, but that seems overkill to avoid a sleep in a test that already requires them. Tree-SHA512: 32de75ecba38426323158fda241e37ffae73806d8c0e60b7ad73fb917e9cd25a3e5f0722cbc6f2f7a5b86501221c317783266bc2e3b4697fb120f05898ccc12d
2 parents feda41e + fabcd64 commit cc7ad2f

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

test/functional/p2p_timeouts.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,11 @@ def run_test(self):
7272
]
7373

7474
with self.nodes[0].assert_debug_log(expected_msgs=expected_timeout_logs):
75-
sleep(2)
75+
sleep(3)
76+
# By now, we waited a total of 5 seconds. Off-by-two for two
77+
# reasons:
78+
# * The internal precision is one second
79+
# * Account for network delay
7680
assert not no_verack_node.is_connected
7781
assert not no_version_node.is_connected
7882
assert not no_send_node.is_connected

0 commit comments

Comments
 (0)