rpc/*,rest: Add review-only assertion to EnsureChainman

dongcarl · dongcarl · commit d0abf0bf4295 · 2021-04-05T11:13:54.000-04:00
diff --git a/src/rpc/blockchain.cpp b/src/rpc/blockchain.cpp
@@ -79,6 +79,7 @@ ChainstateManager& EnsureChainman(const std::any& context)
     if (!node.chainman) {
         throw JSONRPCError(RPC_INTERNAL_ERROR, "Node chainman not found");
     }
+    WITH_LOCK(::cs_main, CHECK_NONFATAL(std::addressof(g_chainman) == std::addressof(*node.chainman)));
     return *node.chainman;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -79,6 +79,7 @@ ChainstateManager& EnsureChainman(const std::any& context)`
`79`	`79`	`if (!node.chainman) {`
`80`	`80`	`throw JSONRPCError(RPC_INTERNAL_ERROR, "Node chainman not found");`
`81`	`81`	`}`
	`82`	`+ WITH_LOCK(::cs_main, CHECK_NONFATAL(std::addressof(g_chainman) == std::addressof(*node.chainman)));`
`82`	`83`	`return *node.chainman;`
`83`	`84`	`}`
`84`	`85`