use const reference as param in ConnectThroughProxy/Socks5

Philip Kaufmann · Philip Kaufmann · commit d1af89e655d7 · 2015-04-28T14:44:56.000+02:00
- also ensure code style conformance by replacing bool static with static bool
diff --git a/src/netbase.cpp b/src/netbase.cpp
@@ -293,7 +293,7 @@ struct ProxyCredentials
 };
 
 /** Connect using SOCKS5 (as described in RFC1928) */
-bool static Socks5(string strDest, int port, const ProxyCredentials *auth, SOCKET& hSocket)
+static bool Socks5(const std::string& strDest, int port, const ProxyCredentials *auth, SOCKET& hSocket)
 {
     LogPrintf("SOCKS5 connecting %s\n", strDest);
     if (strDest.size() > 255) {
@@ -558,7 +558,7 @@ bool IsProxy(const CNetAddr &addr) {
     return false;
 }
 
-static bool ConnectThroughProxy(const proxyType &proxy, const std::string strDest, int port, SOCKET& hSocketRet, int nTimeout, bool *outProxyConnectionFailed)
+static bool ConnectThroughProxy(const proxyType &proxy, const std::string& strDest, int port, SOCKET& hSocketRet, int nTimeout, bool *outProxyConnectionFailed)
 {
     SOCKET hSocket = INVALID_SOCKET;
     // first connect to proxy server

Original file line number	Diff line number	Diff line change
`@@ -293,7 +293,7 @@ struct ProxyCredentials`
`293`	`293`	`};`
`294`	`294`
`295`	`295`	`/** Connect using SOCKS5 (as described in RFC1928) */`
`296`		`-bool static Socks5(string strDest, int port, const ProxyCredentials *auth, SOCKET& hSocket)`
	`296`	`+static bool Socks5(const std::string& strDest, int port, const ProxyCredentials *auth, SOCKET& hSocket)`
`297`	`297`	`{`
`298`	`298`	`LogPrintf("SOCKS5 connecting %s\n", strDest);`
`299`	`299`	`if (strDest.size() > 255) {`
`@@ -558,7 +558,7 @@ bool IsProxy(const CNetAddr &addr) {`
`558`	`558`	`return false;`
`559`	`559`	`}`
`560`	`560`
`561`		`-static bool ConnectThroughProxy(const proxyType &proxy, const std::string strDest, int port, SOCKET& hSocketRet, int nTimeout, bool *outProxyConnectionFailed)`
	`561`	`+static bool ConnectThroughProxy(const proxyType &proxy, const std::string& strDest, int port, SOCKET& hSocketRet, int nTimeout, bool *outProxyConnectionFailed)`
`562`	`562`	`{`
`563`	`563`	`SOCKET hSocket = INVALID_SOCKET;`
`564`	`564`	`// first connect to proxy server`