Bugfix: Do not add sensitive information to history for real

luke-jr · luke-jr · commit de8980df9d3a · 2016-12-29T11:43:29.000Z
Original code was missing braces, and short-circuited before checking everything after importprivkey
diff --git a/src/qt/rpcconsole.cpp b/src/qt/rpcconsole.cpp
@@ -768,7 +768,10 @@ void RPCConsole::on_lineEdit_returnPressed()
         Q_FOREACH(QString unallowedCmd, historyFilter)
         {
             if (cmd.trimmed().startsWith(unallowedCmd))
-                storeHistory = false; break;
+            {
+                storeHistory = false;
+                break;
+            }
         }
 
         if (storeHistory)

Original file line number	Diff line number	Diff line change
`@@ -768,7 +768,10 @@ void RPCConsole::on_lineEdit_returnPressed()`
`768`	`768`	`Q_FOREACH(QString unallowedCmd, historyFilter)`
`769`	`769`	`{`
`770`	`770`	`if (cmd.trimmed().startsWith(unallowedCmd))`
`771`		`- storeHistory = false; break;`
	`771`	`+ {`
	`772`	`+ storeHistory = false;`
	`773`	`+ break;`
	`774`	`+ }`
`772`	`775`	`}`
`773`	`776`
`774`	`777`	`if (storeHistory)`