Fix subscript[0] bug in net.cpp if GetGroup returns a 0-sized vector

JeremyRubin · JeremyRubin · commit e0451e3e2af6 · 2017-07-08T13:31:47.000-07:00
diff --git a/src/net.cpp b/src/net.cpp
@@ -2876,5 +2876,5 @@ uint64_t CConnman::CalculateKeyedNetGroup(const CAddress& ad) const
 {
     std::vector<unsigned char> vchNetGroup(ad.GetGroup());
 
-    return GetDeterministicRandomizer(RANDOMIZER_ID_NETGROUP).Write(&vchNetGroup[0], vchNetGroup.size()).Finalize();
+    return GetDeterministicRandomizer(RANDOMIZER_ID_NETGROUP).Write(vchNetGroup.data(), vchNetGroup.size()).Finalize();
 }

Original file line number	Diff line number	Diff line change
`@@ -2876,5 +2876,5 @@ uint64_t CConnman::CalculateKeyedNetGroup(const CAddress& ad) const`
`2876`	`2876`	`{`
`2877`	`2877`	`std::vector<unsigned char> vchNetGroup(ad.GetGroup());`
`2878`	`2878`
`2879`		`- return GetDeterministicRandomizer(RANDOMIZER_ID_NETGROUP).Write(&vchNetGroup[0], vchNetGroup.size()).Finalize();`
	`2879`	`+ return GetDeterministicRandomizer(RANDOMIZER_ID_NETGROUP).Write(vchNetGroup.data(), vchNetGroup.size()).Finalize();`
`2880`	`2880`	`}`