Skip to content

Commit e157b98

Browse files
committed
Merge bitcoin/bitcoin#25165: doc: Explain squashing with merge commits
fa2d226 doc: Explain squashing with merge commits (MacroFake) Pull request description: This avoids having to explain it in each thread ACKs for top commit: laanwj: ACK fa2d226 Tree-SHA512: e1533ee7c0ab0101c78aaebed97dc889b5eb941cf4c2dfbabbb5f0ec1bb7b1313a1a2e2405235d68c761f039373cebac67ce691a72c820a9252429d50c1ac7d5
2 parents beb18d3 + fa2d226 commit e157b98

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

CONTRIBUTING.md

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -216,9 +216,9 @@ Please update the resulting commit message, if needed. It should read as a
216216
coherent message. In most cases, this means not just listing the interim
217217
commits.
218218

219-
If you have problems with squashing or other git workflows, you can enable
220-
"Allow edits from maintainers" in the right-hand sidebar of the GitHub web
221-
interface and ask for help in the pull request.
219+
If your change contains a merge commit, the above workflow may not work and you
220+
will need to remove the merge commit first. See the next section for details on
221+
how to rebase.
222222

223223
Please refrain from creating several pull requests for the same change.
224224
Use the pull request that is already open (or was created earlier) to amend
@@ -231,7 +231,9 @@ pull request to pull request.
231231
### Rebasing Changes
232232

233233
When a pull request conflicts with the target branch, you may be asked to rebase it on top of the current target branch.
234-
The `git rebase` command will take care of rebuilding your commits on top of the new base.
234+
235+
git fetch https://github.com/bitcoin/bitcoin # Fetch the latest upstream commit
236+
git rebase FETCH_HEAD # Rebuild commits on top of the new base
235237

236238
This project aims to have a clean git history, where code changes are only made in non-merge commits. This simplifies
237239
auditability because merge commits can be assumed to not contain arbitrary code changes. Merge commits should be signed,

0 commit comments

Comments
 (0)